Code review comment for lp:~gandelman-a/ubuntu/oneiric/cobbler/lp850880-850866
Revision history for this message
| Adam Gandelman (gandelman-a) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Hi Scott-
Just pushed some changes which address your 3 points. I agree global variables suck, but to do anything to properly get rid of them at this point would be a major rewrite of the script itself. Perhaps this is something we should address next cycle, maybe thinking about a better way to go about managing a local ISO cache.
I'd prefer to get these changes worked out and tested before changing the default behavior of the script, but I agree that it should probably do all this by default. And +1 to trying to get the same support in cobbler upstream. In the meantime, the --check and --update stuff should be enough.