Merge lp:~gandelman-a/ubuntu/lucid/facter/732953_fixregress into lp:ubuntu/lucid-proposed/facter

Proposed by Adam Gandelman
Status: Merged
Merged at revision: 14
Proposed branch: lp:~gandelman-a/ubuntu/lucid/facter/732953_fixregress
Merge into: lp:ubuntu/lucid-proposed/facter
Diff against target: 28 lines (+10/-1)
2 files modified
debian/changelog (+7/-0)
lib/facter/ec2.rb (+3/-1)
To merge this branch: bzr merge lp:~gandelman-a/ubuntu/lucid/facter/732953_fixregress
Reviewer Review Type Date Requested Status
Ubuntu Development Team Pending
Review via email: mp+81483@code.launchpad.net

Description of the change

Fixes a regression introduced in last SRU where timeouts are not being properly rescued.

To post a comment you must log in.
14. By Adam Gandelman

debian/changelog: Update bug reference.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-10-25 10:28:17 +0000
3+++ debian/changelog 2011-11-07 20:28:25 +0000
4@@ -1,3 +1,10 @@
5+facter (1.5.6-2ubuntu2.3) lucid-proposed; urgency=low
6+
7+ * lib/facter/ec2.rb: Rescue condition in can_connect() when timeout()
8+ actually has a chance to timeout. (LP: #885998)
9+
10+ -- Adam Gandelman <adamg@canonical.com> Mon, 07 Nov 2011 10:18:18 -0800
11+
12 facter (1.5.6-2ubuntu2.2) lucid-proposed; urgency=low
13
14 * lib/facter/ec2.rb: Properly handle ip+port when testing connectivity
15
16=== modified file 'lib/facter/ec2.rb'
17--- lib/facter/ec2.rb 2011-10-25 10:28:17 +0000
18+++ lib/facter/ec2.rb 2011-11-07 20:28:25 +0000
19@@ -9,7 +9,9 @@
20 url = "http://#{ip}:#{port}"
21 Timeout::timeout(wait_sec) {open(url)}
22 return true
23-rescue
24+ rescue Timeout::Error
25+ return false
26+ rescue
27 return false
28 end
29

Subscribers

People subscribed via source and target branches