Merge lp:~gandelman-a/glance/lp828719 into lp:glance/diablo

Proposed by Adam Gandelman
Status: Needs review
Proposed branch: lp:~gandelman-a/glance/lp828719
Merge into: lp:glance/diablo
Diff against target: 46 lines (+2/-5)
2 files modified
Authors (+1/-0)
glance/common/config.py (+1/-5)
To merge this branch: bzr merge lp:~gandelman-a/glance/lp828719
Reviewer Review Type Date Requested Status
OpenStack Infra Pending
Review via email: mp+72773@code.launchpad.net

Description of the change

Resolves bug #828719, which can potentially cause problems depending on what $PWD commands are executed in.

To post a comment you must log in.

Unmerged revisions

206. By Adam Gandelman

Update Authors

205. By Adam Gandelman

Remove "." from list of possible config_file_dirs (LP #828719)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Authors'
2--- Authors 2011-08-15 19:58:57 +0000
3+++ Authors 2011-08-24 18:46:17 +0000
4@@ -1,3 +1,4 @@
5+Adam Gandelman <adamg@canonical.com>
6 Andrey Brindeyev <abrindeyev@griddynamics.com>
7 Brian Lamar <brian.lamar@rackspace.com>
8 Brian Waldon <brian.waldon@rackspace.com>
9
10=== modified file 'glance/common/config.py'
11--- glance/common/config.py 2011-08-11 20:15:33 +0000
12+++ glance/common/config.py 2011-08-24 18:46:17 +0000
13@@ -189,7 +189,6 @@
14 * If --config-file option is used, use that
15 * If args[0] is a file, use that
16 * Search for $app.conf in standard directories:
17- * .
18 * ~.glance/
19 * ~
20 * /etc/glance
21@@ -207,8 +206,7 @@
22 return fix_path(args[0])
23
24 # Handle standard directory search for $app_name.conf
25- config_file_dirs = [fix_path(os.getcwd()),
26- fix_path(os.path.join('~', '.glance')),
27+ config_file_dirs = [fix_path(os.path.join('~', '.glance')),
28 fix_path('~'),
29 '/etc/glance/',
30 '/etc']
31@@ -228,7 +226,6 @@
32 * If --config-file option is used, use that
33 * If args[0] is a file, use that
34 * Search for $app_name.conf in standard directories:
35- * .
36 * ~.glance/
37 * ~
38 * /etc/glance
39@@ -264,7 +261,6 @@
40 * If --config-file option is used, use that
41 * If args[0] is a file, use that
42 * Search for $app_name.conf in standard directories:
43- * .
44 * ~.glance/
45 * ~
46 * /etc/glance

Subscribers

People subscribed via source and target branches

to all changes: