Merge lp:~gandelman-a/glance/fixdeps into lp:~openstack-ubuntu-packagers/glance/ubuntu

Proposed by Adam Gandelman
Status: Merged
Merged at revision: 75
Proposed branch: lp:~gandelman-a/glance/fixdeps
Merge into: lp:~openstack-ubuntu-packagers/glance/ubuntu
Diff against target: 32 lines (+10/-1)
2 files modified
debian/changelog (+2/-0)
debian/control (+8/-1)
To merge this branch: bzr merge lp:~gandelman-a/glance/fixdeps
Reviewer Review Type Date Requested Status
Chuck Short (community) Approve
Review via email: mp+85795@code.launchpad.net

Description of the change

Fixes some dependency issues for the api and registry servers that were caused by a previous Depends cleanup of the client package.

To post a comment you must log in.
Revision history for this message
Chuck Short (zulcss) wrote :

lgtm

Revision history for this message
Chuck Short (zulcss) :
review: Approve
Revision history for this message
Jay Pipes (jaypipes) wrote :

I deliberately removed the need for things like eventlet from the glance-common package because we didn't want the python-glance package (the client package) having to depend on things like eventlet. Does this patch mean that the python-glance package now requires those packages again?

Revision history for this message
Adam Gandelman (gandelman-a) wrote :

The dependencies were removed from the client / python-glance package (on which the old all-in-one glance server package depended upon) There was no glance-common package at the time. Now that api and registry live in their own respective packages, they both depend on glance-common to resolve dependencies like this. python-glance has no dependency on glance-common and is installable without.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-12-08 18:29:33 +0000
3+++ debian/changelog 2011-12-15 06:26:25 +0000
4@@ -10,6 +10,8 @@
5
6 [ Adam Gandelman ]
7 * Only remove user/group in .postrm if they exist. (LP: #857021)
8+ * Add dependencies previously removed from client package to glance-common,
9+ where they are required for glance-{api,registry}
10
11 -- Scott Moser <smoser@ubuntu.com> Wed, 07 Dec 2011 14:10:28 -0500
12
13
14=== modified file 'debian/control'
15--- debian/control 2011-12-10 12:52:14 +0000
16+++ debian/control 2011-12-15 06:26:25 +0000
17@@ -53,7 +53,14 @@
18 Package: glance-common
19 Architecture: all
20 Section: python
21-Depends: ${python:Depends}, ${misc:Depends}, python-glance (= ${source:Version}), adduser
22+Depends: ${python:Depends}, ${misc:Depends},
23+ adduser,
24+ python-eventlet,
25+ python-glance (= ${source:Version}),
26+ python-migrate,
27+ python-routes,
28+ python-sqlalchemy-ext | python-sqlalchemy (<< 0.6.3-2),
29+ python-xattr
30 Description: OpenStack Image Registry and Delivery Service - Common
31 The Glance project provides an image registration, discovery and
32 delivery service. These services may be used as stand-along services, and

Subscribers

People subscribed via source and target branches