Juju Charms Collection
rabbitmq-server package

Merge lp:~gandelman-a/charms/precise/rabbitmq-server/remove_sudo into lp:charms/rabbitmq-server

  1. Precise Pangolin (12.04)
  2. remove_sudo
  3. Merge into trunk
Proposed by Adam Gandelman
Status: Merged
Approved by: Juan L. Negron
Approved revision: 34
Merge reported by: Juan L. Negron
Merged at revision: not available
Proposed branch: lp:~gandelman-a/charms/precise/rabbitmq-server/remove_sudo
Merge into: lp:charms/rabbitmq-server
Diff against target: 22 lines (+1/-6)
2 files modified
hooks/rabbitmq-relations (+0/-5)
revision (+1/-1)
To merge this branch: bzr merge lp:~gandelman-a/charms/precise/rabbitmq-server/remove_sudo
Reviewer Review Type Date Requested Status
Juan L. Negron (community) Approve
Review via email: mp+124508@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Juan L. Negron (negronjl) wrote :

Reviewing this now.

-Juan

Revision history for this message
Juan L. Negron (negronjl) wrote :

Approved.

I don't understand why we had sudo anyway.

-Juan

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/rabbitmq-relations'
2--- hooks/rabbitmq-relations 2012-05-03 23:12:07 +0000
3+++ hooks/rabbitmq-relations 2012-09-14 20:09:32 +0000
4@@ -37,11 +37,6 @@
5 DEBIAN_FRONTEND=noninteractive apt-get -qqy \
6 install --no-install-recommends rabbitmq-server
7 rc=$?
8-
9- # give ubuntu user passwd-less sudo for log access
10- echo "ubuntu ALL=(ALL) NOPASSWD:ALL" >/etc/sudoers.d/ubuntu-qa
11- chmod 0440 /etc/sudoers.d/ubuntu-qa
12-
13 service rabbitmq-server stop
14 }
15
16
17=== modified file 'revision'
18--- revision 2012-09-06 13:20:01 +0000
19+++ revision 2012-09-14 20:09:32 +0000
20@@ -1,1 +1,1 @@
21-34
22+35

Subscribers

People subscribed via source and target branches