Merge lp:~gandelman-a/charms/precise/glance/swift_redux into lp:~charmers/charms/precise/glance/trunk

[Adam Gandelman]

Update object-store relations for swift integration. This stuff wasn't touched since the Diablo days

[lp:~gandelman-a/charms/precise/glance/swift_redux]

27. By Adam Gandelman on 2012-12-18

metadata.yaml: Update object-store interface to match new scheme.

[James Page (james-page)]

The swift changes are just fine; however the charm could really do with a README!

I won't block on that but it would be great to see one soon.

review: Approve

=== modified file 'hooks/glance-relations'
--- hooks/glance-relations	2012-11-20 12:34:27 +0000
+++ hooks/glance-relations	2012-12-18 20:01:24 +0000
@@ -98,20 +98,40 @@
   relation-set glance-api-server="$bind_host:$bind_port"
 }
 
-function object-store_changed {
-  URL=`relation-get url`
-  USER=`relation-get user`
-  PASSWORD=`relation-get password`
-  [[ -z $URL ]] || [[ -z $USER ]] || [[ -z $PASSWORD ]] && \
-    echo "URL||USER||PASSWORD not set, peer not ready?" && exit 0
+function object-store_joined {
+  local relids="$(relation-ids identity-service)"
+  [[ -z "$relids" ]] && \
+    juju-log "$CHARM: Deferring swift store configuration until " \
+             "an identity-service relation exists." && exit 0
+
   set_or_update default_store swift api
-  set_or_update swift_store_user system:$USER api
-  set_or_update swift_store_key $PASSWORD api
-  set_or_update swift_store_auth_address $URL api
   set_or_update swift_store_create_container_on_put true api
+
+  for relid in $relids ; do
+    local unit=$(relation-list -r $relid)
+    local svc_tenant=$(relation-get -r $relid service_tenant $unit)
+    local svc_username=$(relation-get -r $relid service_username $unit)
+    local svc_password=$(relation-get -r $relid service_password $unit)
+    local auth_host=$(relation-get -r $relid private-address $unit)
+    local port=$(relation-get -r $relid service_port $unit)
+    local auth_url=""
+
+    [[ -n "$auth_host" ]] && [[ -n "$port" ]] &&
+      auth_url="http://$auth_host:$port/v2.0/"
+
+    [[ -n "$svc_tenant" ]] && [[ -n "$svc_username" ]] &&
+      set_or_update swift_store_user "$svc_tenant:$svc_username" api
+    [[ -n "$svc_password" ]] &&
+      set_or_update swift_store_key "$svc_password" api
+    [[ -n "$auth_url" ]] &&
+      set_or_update swift_store_auth_address "$auth_url" api
+  done
   service_ctl glance-api restart
 }
 
+function object-store_changed {
+  exit 0
+}
 
 function ceph_joined {
   mkdir -p /etc/ceph
@@ -217,6 +237,10 @@
     set_or_update "admin_password" "$service_password" $i
   done
   service_ctl all restart
+
+  # Configure any object-store / swift relations now that we have an
+  # identity-service
+  object-store_joined
 }
 
 function config_changed() {
@@ -243,7 +267,7 @@
   "shared-db-relation-changed") db_changed;;
   "image-service-relation-joined") image-service_joined ;;
   "image-service-relation-changed") exit 0 ;;
-  "object-store-relation-joined") exit 0 ;;
+  "object-store-relation-joined") object-store_joined ;;
   "object-store-relation-changed") object-store_changed ;;
   "identity-service-relation-joined") keystone_joined ;;
   "identity-service-relation-changed") keystone_changed ;;

=== modified file 'metadata.yaml'
--- metadata.yaml	2012-10-11 15:14:23 +0000
+++ metadata.yaml	2012-12-18 20:01:24 +0000
@@ -14,7 +14,7 @@
   shared-db:
     interface: mysql-shared
   object-store:
-    interface: swift
+    interface: swift-proxy
   identity-service:
     interface: keystone
   ceph:

=== modified file 'revision'
--- revision	2012-10-25 15:37:36 +0000
+++ revision	2012-12-18 20:01:24 +0000
@@ -1,1 +1,1 @@
-72
+75