Merge lp:~gandelman-a/charms/oneiric/swift-storage/interface_update into lp:charms/oneiric/swift-storage

Proposed by Adam Gandelman
Status: Rejected
Rejected by: Jorge Castro
Proposed branch: lp:~gandelman-a/charms/oneiric/swift-storage/interface_update
Merge into: lp:charms/oneiric/swift-storage
Diff against target: 40 lines (+6/-6)
2 files modified
hooks/swift-storage-node-relations (+2/-2)
metadata.yaml (+4/-4)
To merge this branch: bzr merge lp:~gandelman-a/charms/oneiric/swift-storage/interface_update
Reviewer Review Type Date Requested Status
Juan L. Negron (community) Disapprove
Review via email: mp+91751@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

Excerpts from Adam Gandelman's message of Tue Feb 07 01:46:15 UTC 2012:
> Adam Gandelman has proposed merging lp:~gandelman-a/charms/oneiric/swift-storage/interface_update into lp:charms/swift-storage.
>
> Requested reviews:
> charmers (charmers)
>
> For more details, see:
> https://code.launchpad.net/~gandelman-a/charms/oneiric/swift-storage/interface_update/+merge/91751

Swift-storage doesn't require the proxy, it provides an endpoint to the proxy.

Revision history for this message
Adam Gandelman (gandelman-a) wrote :

Perhaps its misleading language, but I'd argue the storage nodes absolutely require the proxy. swift-proxy is responsible for resolving requests to specific machines and devices within the storage ring. One cannot function without the other and the cluster is useless without both.

Revision history for this message
Juan L. Negron (negronjl) wrote :

Reviewing now.

-Juan

Revision history for this message
Juan L. Negron (negronjl) wrote :

I cannot find either of the branches ... so I have to reject this.

Adam:

If this code is now somewhere else, let me know.

-Juan

review: Disapprove
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

This isn't a merge proposal issue, just an lp hosting issue with launchpad

Unmerged revisions

9. By Adam Gandelman

metadata: Update interfaces

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added symlink 'hooks/proxy-relation-changed'
2=== target is u'swift-storage-node-relations'
3=== added symlink 'hooks/proxy-relation-joined'
4=== target is u'swift-storage-node-relations'
5=== removed symlink 'hooks/swift-proxy-relation-changed'
6=== target was u'swift-storage-node-relations'
7=== removed symlink 'hooks/swift-proxy-relation-joined'
8=== target was u'swift-storage-node-relations'
9=== modified file 'hooks/swift-storage-node-relations'
10--- hooks/swift-storage-node-relations 2011-10-12 06:11:05 +0000
11+++ hooks/swift-storage-node-relations 2012-02-07 01:44:21 +0000
12@@ -49,6 +49,6 @@
13 case $ARG0 in
14 "install") install_hook ;;
15 "start"|"stop") exit 0 ;;
16- "swift-proxy-relation-joined") proxy_joined ;;
17- "swift-proxy-relation-changed") proxy_changed ;;
18+ "proxy-relation-joined") proxy_joined ;;
19+ "proxy-relation-changed") proxy_changed ;;
20 esac
21
22=== modified file 'metadata.yaml'
23--- metadata.yaml 2011-10-12 06:11:05 +0000
24+++ metadata.yaml 2012-02-07 01:44:21 +0000
25@@ -4,11 +4,11 @@
26 description: |
27 Contains swift-object, swift-container and swift-account servers.
28 provides:
29- swift-storage:
30- interface: swift
31+ storage-ring:
32+ interface: swift-storage
33 requires:
34- swift-proxy:
35- interface: swift
36+ proxy:
37+ interface: swift-proxy
38 peers:
39 swift-ring:
40 interface: swift

Subscribers

People subscribed via source and target branches

to all changes: