Juju Charms Collection
nova-cloud-controller package

Merge lp:~gandelman-a/charms/oneiric/nova-cloud-controller/901828 into lp:~charmers/charms/oneiric/nova-cloud-controller/trunk

  1. Oneiric (11.10)
  2. 901828
  3. Merge into trunk
Proposed by Adam Gandelman
Status: Merged
Approved by: Clint Byrum
Approved revision: 22
Merge reported by: Adam Gandelman
Merged at revision: not available
Proposed branch: lp:~gandelman-a/charms/oneiric/nova-cloud-controller/901828
Merge into: lp:~charmers/charms/oneiric/nova-cloud-controller/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
hooks/nova-cloud-controller-relations (+1/-1)
To merge this branch: bzr merge lp:~gandelman-a/charms/oneiric/nova-cloud-controller/901828
Reviewer Review Type Date Requested Status
Clint Byrum (community) Approve
Review via email: mp+85719@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

LGTM

review: Approve
Revision history for this message
Juan L. Negron (negronjl) wrote :

+1 from me too.

This is pretty cool Adam...LGTM 2

-Juan

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/nova-cloud-controller-relations'
2--- hooks/nova-cloud-controller-relations 2011-11-15 01:00:20 +0000
3+++ hooks/nova-cloud-controller-relations 2011-12-14 18:28:24 +0000
4@@ -58,7 +58,7 @@
5 }
6
7 function db_changed {
8- DB_HOST=`relation-get db_host`
9+ DB_HOST=`relation-get private-address`
10 DB_PASSWORD=`relation-get password`
11 if [[ -z $DB_HOST ]] || [[ -z $DB_PASSWORD ]] ; then
12 echo "db_changed: DB_HOST || DB_PASSWORD not yet set. Exit 0 and retry"

Subscribers

People subscribed via source and target branches

to all changes: