Merge lp:~gamag/widelands/bug952404 into lp:widelands

Proposed by Gabriel Margiani
Status: Merged
Merged at revision: 6320
Proposed branch: lp:~gamag/widelands/bug952404
Merge into: lp:widelands
Diff against target: 15 lines (+6/-0)
1 file modified
src/graphic/rendertarget.cc (+6/-0)
To merge this branch: bzr merge lp:~gamag/widelands/bug952404
Reviewer Review Type Date Requested Status
Shevonar Approve
Gabriel Margiani Needs Resubmitting
Review via email: mp+97755@code.launchpad.net

Description of the change

Fixes Bug#952404.
Shall/can I push such little changes
directly to truck in the Future?

To post a comment you must log in.
Revision history for this message
Shevonar (shevonar) wrote :

When we know that m_offset.x < 0 its easier to do ofs.x -= m_offset.x. Could you change that?

review: Needs Fixing
Revision history for this message
Shevonar (shevonar) wrote :

And yes I think you can push such changes directly to trunk.

Revision history for this message
Gabriel Margiani (gamag) :
review: Needs Resubmitting
Revision history for this message
Shevonar (shevonar) wrote :

Thanks for this fix. You should join the Widelands Development Team to commit to trunk yourself, since you do a lot of fixes recently.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/graphic/rendertarget.cc'
2--- src/graphic/rendertarget.cc 2012-03-02 13:21:49 +0000
3+++ src/graphic/rendertarget.cc 2012-03-15 21:47:22 +0000
4@@ -223,6 +223,12 @@
5 int32_t srch = picture->get_h();
6
7 if (clip(r)) {
8+ if (m_offset.x < 0)
9+ ofs.x -= m_offset.x;
10+
11+ if (m_offset.y < 0)
12+ ofs.y -= m_offset.y;
13+
14 // Make sure the offset is within bounds
15 ofs.x = ofs.x % srcw;
16

Subscribers

People subscribed via source and target branches

to status/vote changes: