Merge lp:~gala-dev/gala/swipe-testing into lp:gala

Proposed by Tom Beckmann
Status: Work in progress
Proposed branch: lp:~gala-dev/gala/swipe-testing
Merge into: lp:gala
Diff against target: 33 lines (+14/-2)
1 file modified
src/Widgets/WorkspaceView.vala (+14/-2)
To merge this branch: bzr merge lp:~gala-dev/gala/swipe-testing
Reviewer Review Type Date Requested Status
Gala developers Pending
Review via email: mp+182159@code.launchpad.net

Description of the change

This branch attaches the ClutterSwipeAction to the workspaceview. As I don't have a touchpad/-screen with appropriate support, I'll just put it here and hope that someone can test it to verify that it works. With my mouse, I can get sometimes get it to move when sliding over the screen rapidly. It'll probably only work on the large area above the switcher itself, and, if it works at all, I'll see if we can extend it. Also, I temporarily disabled clicking on that area to close the switcher, as it most likely interferes with the action. Again, without being able to properly test it, I can't really verify it, so I'd add it back in later.

To post a comment you must log in.
lp:~gala-dev/gala/swipe-testing updated
354. By Tom Beckmann

windowthumb: use button-release-event instead of button-press-event to catch problems with unintentional clicks that happen after the modal mode is exited and the release happens

355. By Tom Beckmann

plugin: add the option to assign different commands to each hotcorner while staying compatible to the previous scheme

356. By Tom Beckmann

windowthumb: properly check if a window is not destroyed when asked to close and focus it in that case

Revision history for this message
Danielle Foré (danrabbit) wrote :

fails to build on Saucy http://snippi.com/s/nz293qe

lp:~gala-dev/gala/swipe-testing updated
357. By Rico Tzschichholz

Updates for mutter 3.9.90 api changes

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

@dan: you are building against mutter 3.9.90 ;-)

@tom: I pushed an update to trunk for this. So just rebase this branch on the current trunk.

lp:~gala-dev/gala/swipe-testing updated
359. By Tom Beckmann

disable clicking on the area to close

Revision history for this message
Danielle Foré (danrabbit) wrote :

I can sort of get it to work sometimes, though I'm not sure how.

It doesn't follow my fingers 1:1, so I'm not really sure how many fingers it's expecting or how dramatic the gesture needs to be.

However, I think something I can say consistently is that it seems to be interpreting my swipe backwards. ie: swiping from right to left tries to move the workspace to the left instead of to the right (as in the content is trying to move the opposite direction of my fingers). If it makes a difference (though I think it probably shouldn't) I do have natural scrolling turned on.

Unmerged revisions

359. By Tom Beckmann

disable clicking on the area to close

358. By Tom Beckmann

workspaceview: add support for clutter swipe action

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/WorkspaceView.vala'
2--- src/Widgets/WorkspaceView.vala 2013-06-27 12:05:30 +0000
3+++ src/Widgets/WorkspaceView.vala 2013-08-29 16:17:46 +0000
4@@ -70,8 +70,9 @@
5 click_catcher = new Clutter.Actor ();
6 click_catcher.reactive = true;
7 click_catcher.button_release_event.connect ((e) => {
8- hide ();
9- return true;
10+ //TODO reenable this
11+ // hide ();
12+ return false;
13 });
14 Compositor.get_stage_for_screen (screen).add_child (click_catcher);
15
16@@ -109,6 +110,17 @@
17 });
18
19 init_thumbnails ();
20+
21+ var swipe = new Clutter.SwipeAction ();
22+ swipe.swept.connect ((actor, direction) => {
23+ if (direction == Clutter.SwipeDirection.LEFT) {
24+ switch_to_next_workspace (Meta.MotionDirection.LEFT);
25+ } else if (direction == Clutter.SwipeDirection.RIGHT) {
26+ switch_to_next_workspace (Meta.MotionDirection.RIGHT);
27+ }
28+ });
29+
30+ click_catcher.add_action (swipe);
31 }
32
33 void init_thumbnails ()

Subscribers

People subscribed via source and target branches