Code review comment for lp:~gala-dev/gala/mutter38

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

> I think
>
> add_definitions(-DGETTEXT_PACKAGE=\"${GETTEXT_PACKAGE}\"
> -DGNOME_DESKTOP_USE_UNSTABLE_API)
>
> should become
>
> add_definitions(-DGETTEXT_PACKAGE=\"${GETTEXT_PACKAGE}\")
> add_definitions(-DGNOME_DESKTOP_USE_UNSTABLE_API)
>
> Maybe with some comments above the lines

This is not needed. They would have called it "add_definition" then ;)

« Back to merge proposal