Merge lp:~gala-dev/gala/always-focus-on-map into lp:gala
Status: | Rejected |
---|---|
Rejected by: | Danielle Foré |
Proposed branch: | lp:~gala-dev/gala/always-focus-on-map |
Merge into: | lp:gala |
Diff against target: |
42 lines (+10/-0) 3 files modified
data/org.pantheon.desktop.gala.gschema.xml (+5/-0) src/Plugin.vala (+4/-0) src/Settings.vala (+1/-0) |
To merge this branch: | bzr merge lp:~gala-dev/gala/always-focus-on-map |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gala developers | Pending | ||
Review via email: mp+202686@code.launchpad.net |
Commit message
plugin: add gsettings key toggling whether windows should always be focused when they're mapped
Description of the change
This adds a key always-focus-on-map to gala's behavior gsettings. Once enabled, this will make gala call activate() on each window that is mapped, so windows will always be focused once mapped. Normally, mutter does quite some work to determine whether a newly mapped window should be focused or not, most importantly in our case, if a newer interaction with a different window has occurred since that window was "started". And this very part is currently broken in Gtk, the startup time is not correctly set for multi window apps, like the terminal, and the last interaction with any window of the app is used for the new window for comparision instead. See here: https:/
As the fix proposed in the GNOME bug is part of a larger patch restructuring the GtkApplication code, I don't think we'll be able to backport it. Instead I would propose this temporary fix for luna so we can get rid of this annoying problem, hopefully for isis, we have a Gtk with that patch applied.
An important question to be talked about would also be whether we want to have this enabled by default. Enabling works with a simple "gsettings set org.pantheon.
I've set it to false by default currently, but I doubt the current behavior can be considered better than this.
Relevant gala bug: https:/
Unmerged revisions
- 367. By Tom Beckmann
-
plugin: add gsettings key toggling whether windows should always be focused when they're mapped
As said on IRC. I would prefer to find out what fixed this problem in Gtk+ 3.11.x rather than introducing this additional hacky option ;)