lp:~gagern/trac-bzr/bug177683

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:trac-bzr

Martin von Gagern: Approve on 2009-11-26

Diff: 122 lines (+45/-41)

2 files modified

tracbzr/backend.py (+43/-40)
tracbzr/tests/test_branch.py (+2/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #177683: All revisions and changesets starts with a comma sign	Low	Fix Released
Bug #318839: [patch] osutil and isdigit bugs	Undecided	Fix Released

Link a bug report

Related blueprints

74. By Martin von Gagern on 2009-11-24

Merge warning from LP #274609 fix

73. By Martin von Gagern on 2009-11-23

Take url quoting into account for test_get_changeset.

Now this test succeeds where it used to cause errors before.

72. By Martin von Gagern on 2009-11-23

Major rewrite of _parse_rev.

The main functional difference is that revision identifiers without a branch
name are now always interpreted relative to the default branch, i.e. a
branch located at the repository root, with empty relative path. As the
main case distinction between revs with and without branches becomes
obsolete, indentation changes a lot, but actual code not quite as much.

This interpretation is consistent with the interpretation of a revision
number without a branch, consistent with the docstring comment of
_parse_rev, consistent with the way _string_rev_revid handles an empty
branch name. It completes the fix for LP #177683 by handling the revision
parsing, and it answers LP #486795 by choosing alternative 3 described
there.

As a minor side-effect, the implementation does url unquoting first and
interpretation as a (possibly dotted) revno second. So where any url-quoted
string would always have been interpreted as a revid before, it will be
interpreted as a revno now. Since we didn't have any functionality to
urlencode digit-only revids, and as such revids probably don't occur in the
wild in any case, this seems acceptable and consistent.

71. By Martin von Gagern on 2009-11-23

Merge fix for LP #274609

70. By Martin von Gagern on 2009-11-19

Do additional conversions to string for trac revision identifiers.
Fixes LP #177683 comment #9.

69. By David Allouche on 2009-06-03

Fix TypeError, comparison of offset-naive and offset-aware datetimes.

In commit 60, Jelmer said: "All timestamps are utc by default."

That is not true. By default, datetimes are offset-naive,
but Trac uses offset-aware datetimes internally.

68. By Jelmer Vernooij on 2009-05-06

Avoid _get_weave.

67. By Jelmer Vernooij on 2009-05-06

Use constants for current: revision.

66. By Jelmer Vernooij on 2009-05-06

Merge fix for bug 303327.

65. By Jelmer Vernooij on 2009-05-05

use constants for null: and current: