Merge lp:~gagern/bzr-gentoo-overlay/bzr-bash-completion into lp:~malept/bzr-gentoo-overlay/overlay-main

[Martin von Gagern]

The bash completion script shipped with bzr is horribly outdated. And with the plugin infrastructure of bzr, no static completion script can ever hope to deal with all options in a reasonable way.

To deal with these issues, I've written a bzr plugin that generates a suitable completion function dynamically. This ebuild installs the plugin. It also installs a small static function for eselect-able bash completion, which will generate the full completion function upon first invocation. This lazy generation prevents long bash initialization delays.

[Christian Faulhammer (fauli)]

Have you contacted the bzr developers about it?

[Martin von Gagern (gagern)]

> Have you contacted the bzr developers about it?

I've told them when I started the project:
https://lists.ubuntu.com/archives/bazaar/2009q3/062773.html

Back then I didn't have the lazy init, but I assume bzr devs interested would have noted the project and followed it since. Not sure, though.

http://wiki.bazaar.canonical.com/BzrPlugins#line-166 also lists the plugin "officially", so there is another way for people to notice it.

[Mark Lee (malept)]

Merged by inference (as it was already merged in the bzr-overlay-dev branch).

Although as a user, I would greatly prefer it if you could try to get it into bzr core, (file a bug!) replacing the (less than ideal) bash completion scripts that are bundled.

review: Approve

=== added directory 'dev-vcs/bzr-bash-completion'
=== added file 'dev-vcs/bzr-bash-completion/ChangeLog'
--- dev-vcs/bzr-bash-completion/ChangeLog	1970-01-01 00:00:00 +0000
+++ dev-vcs/bzr-bash-completion/ChangeLog	2010-03-15 13:53:13 +0000
@@ -0,0 +1,10 @@
+# ChangeLog for dev-vcs/bzr-bash-completion
+# Copyright 1999-2010 Gentoo Foundation; Distributed under the GPL v2
+# $Header: $
+
+*bzr-bash-completion-1.0.2 (15 Mar 2010)
+
+  15 Mar 2010; Martin von Gagern (MvG) <[e-mail]>
+  +bzr-bash-completion-1.0.2.ebuild, +metadata.xml:
+  Initial ebuild.
+

=== added file 'dev-vcs/bzr-bash-completion/Manifest'
--- dev-vcs/bzr-bash-completion/Manifest	1970-01-01 00:00:00 +0000
+++ dev-vcs/bzr-bash-completion/Manifest	2010-03-15 13:53:13 +0000
@@ -0,0 +1,4 @@
+DIST bzr-bash-completion-1.0.2.tar.gz 7603 RMD160 f6be64105921655923083f89e1cb381cd8069032 SHA1 7e0b5764121b9ac6937cff36ad414c6743a21850 SHA256 37c3bbc8e0a0f76c4aee87db7dc887a5a78b9a0a5096922992d46a2606905943
+EBUILD bzr-bash-completion-1.0.2.ebuild 1037 RMD160 97b57b0038e81513cc486c3313e4b2f3562b62ea SHA1 c220826a2d659bb4faccf1a34337b62abd6798c9 SHA256 dc46c62b349cbca433c35e0aa02d30f6ac0532d36a589390eda71abc80be9268
+MISC ChangeLog 305 RMD160 054a5f333b70cd190edb3be7432e75084ea8f939 SHA1 81b138463e4b072df41085291aa00d9180a5bb70 SHA256 b17015bf99b4bedb0b0b393efe13ba700450cd4dbd232a656346cdb653f15718
+MISC metadata.xml 313 RMD160 5037f6aeced048ad62d0272cec44453ca30ff6f8 SHA1 3e6242d576c2421aa19b7afbda6b27536a16103a SHA256 69c8b1939eb2abfa9f8e01cdb75c66185ac7430130f6aedcb82217d7d8a441f0

=== added file 'dev-vcs/bzr-bash-completion/bzr-bash-completion-1.0.2.ebuild'
--- dev-vcs/bzr-bash-completion/bzr-bash-completion-1.0.2.ebuild	1970-01-01 00:00:00 +0000
+++ dev-vcs/bzr-bash-completion/bzr-bash-completion-1.0.2.ebuild	2010-03-15 13:53:13 +0000
@@ -0,0 +1,37 @@
+# Copyright 1999-2010 Gentoo Foundation
+# Distributed under the terms of the GNU General Public License v2
+# $Header: $
+
+EAPI=2
+
+inherit distutils
+
+DESCRIPTION="Bash completion for the bazaar bzr command"
+HOMEPAGE="https://launchpad.net/${PN}"
+SRC_URI="http://pypi.python.org/packages/source/${PN:0:1}/${PN}/${P}.tar.gz"
+
+LICENSE="GPL2"
+SLOT="0"
+KEYWORDS="~amd64 ~x86"
+IUSE=""
+
+DEPEND=""
+RDEPEND=">=app-shells/bash-completion-1.1-r5
+	dev-vcs/bzr[-bash-completion]"
+
+src_prepare() {
+	distutils_src_prepare || die "Failed to prepare python code"
+
+	# Other bash-completion functions don't set progcomp either
+	sed -i '/^shopt -s progcomp$/d' lazy.sh
+}
+
+src_install() {
+	distutils_src_install || die "Failed to install python code"
+
+	# we cannot use dobashcompletion from bash-completion.eclass, as
+	# that eclass assumes a bash-completion IUSE, which we don't want.
+	# So we have to copy its functionality. All two lines of it. :-)
+	insinto /usr/share/bash-completion
+	newins lazy.sh bzr || die "Failed to install lazy completion script"
+}

=== added file 'dev-vcs/bzr-bash-completion/metadata.xml'
--- dev-vcs/bzr-bash-completion/metadata.xml	1970-01-01 00:00:00 +0000
+++ dev-vcs/bzr-bash-completion/metadata.xml	2010-03-15 13:53:13 +0000
@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE pkgmetadata SYSTEM "http://www.gentoo.org/dtd/metadata.dtd">
+<pkgmetadata>
+  <herd>no-herd</herd>
+  <maintainer>
+    <email>[e-mail]</email>
+    <description>bzr-bash-completion maintainer and Gentoo user</description>
+  </maintainer>
+</pkgmetadata>