Merge ~gabrielzchen/plainbox-provider-checkbox:dock-and-pm into plainbox-provider-checkbox:master

Proposed by Gabriel Zhi Chen
Status: Rejected
Rejected by: Gabriel Zhi Chen
Proposed branch: ~gabrielzchen/plainbox-provider-checkbox:dock-and-pm
Merge into: plainbox-provider-checkbox:master
Diff against target: 82 lines (+18/-7)
4 files modified
units/dock/jobs.pxu (+5/-3)
units/dock/test-plan.pxu (+0/-4)
units/keys/jobs.pxu (+12/-0)
units/keys/test-plan.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Devices Certification Bot Needs Fixing
Sylvain Pineau Needs Fixing
Betty Lin (community) Approve
Jerry Kao (community) Approve
Review via email: mp+377348@code.launchpad.net

Commit message

1. Add the power-button test case,
2. Modify the steps of audio-playback-headphones and audio-alsa-record-playback-external cases,
3.Remove the cases audio-speaker-headphone-plug-detection and audio-microphone-plug-detection.

To post a comment you must log in.
Revision history for this message
Jerry Kao (jerry.kao) wrote :

+1

review: Approve
Revision history for this message
Betty Lin (bettyl) wrote :

LGTM +1

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[bionic] [09:25:06] starting container
Device project added to bionic-testing
[bionic] [09:25:19] provisioning container
[bionic] [09:27:31] Unable to provision requirements in container!
[bionic] output: https://paste.ubuntu.com/p/kr6cHH3J8X/
[bionic] [09:27:34] Fixing file permissions in source directory
[bionic] Destroying failed container to reclaim resources
[xenial] [09:28:50] starting container
Device project added to xenial-testing
[xenial] [09:28:59] provisioning container
[xenial] [09:29:19] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-checkbox
[xenial] [10:05:21] container-tests-provider-checkbox: FAIL
[xenial] output: https://paste.ubuntu.com/p/xF36w7vHM6/
[xenial] [10:05:23] Fixing file permissions in source directory
[xenial] [10:05:24] Destroying container

review: Needs Fixing
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[xenial] [01:46:04] starting container
[bionic] [01:46:06] starting container
Device project added to xenial-testing
Device project added to bionic-testing
[xenial] [01:46:14] provisioning container
[bionic] [01:46:18] provisioning container
[bionic] [01:46:35] Starting tests...
[bionic] Found a test script: ./requirements/container-tests-provider-checkbox
[xenial] [01:46:36] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-checkbox
[bionic] [01:47:37] container-tests-provider-checkbox: FAIL
[bionic] output: https://paste.ubuntu.com/p/fHgmWqgT8g/
[bionic] [01:47:40] Fixing file permissions in source directory
[bionic] [01:47:40] Destroying container
[xenial] [01:47:41] container-tests-provider-checkbox: FAIL
[xenial] output: https://paste.ubuntu.com/p/FNChFQSWpn/
[xenial] [01:47:44] Fixing file permissions in source directory
[xenial] [01:47:44] Destroying container

review: Needs Fixing
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

There's a validation problem, nothing related to lp:

error: units/keys/jobs.pxu:280-291: job 'keys/power-button', field 'description', manual jobs must have a description field, or a set of purpose, steps, and verification fields

review: Needs Fixing
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

I tried to merge it but there are some problems. Typically you want to merge or rebase and try again.

review: Needs Fixing
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[bionic] [08:33:37] starting container
[xenial] [08:33:37] starting container
Device project added to bionic-testing
Device project added to xenial-testing
[xenial] [08:33:46] provisioning container
[bionic] [08:33:50] provisioning container
[xenial] [08:34:07] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-checkbox
[bionic] [08:34:09] Starting tests...
[bionic] Found a test script: ./requirements/container-tests-provider-checkbox
[xenial] [08:35:01] container-tests-provider-checkbox: FAIL
[xenial] output: https://paste.ubuntu.com/p/PTGBHG4T9r/
[xenial] [08:35:04] Fixing file permissions in source directory
[xenial] [08:35:04] Destroying container
[bionic] [08:35:15] container-tests-provider-checkbox: FAIL
[bionic] output: https://paste.ubuntu.com/p/HJ4CYDH5Tx/
[bionic] [08:35:18] Fixing file permissions in source directory
[bionic] [08:35:18] Destroying container

review: Needs Fixing
Revision history for this message
Jonathan Cave (jocave) wrote :

@Gabriel please fix this and set back to Needs Review if you want it to land still

Revision history for this message
OEM Taipei Bot (oem-taipei-bot) wrote :

Execute `curl -X POST http://10.102.135.31/api/v1/teams/self-contained/pipelines/plainbox-provider-checkbox/resources/merge-proposal-377348/check/webhook?webhook_token=merge-proposal-377348` within TW VPN to restart the test.
[autopkgtest]
$ cat plainbox-provider-checkbox-0.59.0-1-0af7fa5-in-linux-container-focal-summary.log
bootstrap-client-cert-desktop-20-04-automated FAIL stderr: unable to find nested part: com.canonical.certification::submission-cert-automated
https://oem-share.canonical.com/partners/lyoncore/share/artifacts/plainbox-provider-checkbox-0.59.0-1-0af7fa5-in-linux-container-focal

Revision history for this message
Gabriel Zhi Chen (gabrielzchen) wrote :

@Jonathan, Please skip the MR, The MR is out of date and it is no longer suitable for current testing. Thanks for the notice.

Unmerged commits

0af7fa5... by Gabriel Zhi Chen

Remove the Leading space before _purpose, _steps and _verificaion

f533e71... by Gabriel Zhi Chen

1. Add the power-button test case,2. Modify the steps of audio-playback-headphones and audio-alsa-record-playback-external cases,3.Remove the cases audio-speaker-headphone-plug-detection and audio-microphone-plug-detection.

de3595e... by PMR <pmr@pmr-lander>

Merge #377102 from ~bettyl/plainbox-provider-checkbox:remove-obex-tests

a3b1b3f... by PMR <pmr@pmr-lander>

Merge #377003 from ~jocave/plainbox-provider-checkbox:chameleon-edid-stress

72bc0d9... by Jonathan Cave

monitor: add EDID stress test using chameleon

Imports a set of EDID example data from chromiomos project and
loads these one at a time in to the Chamelon board.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/dock/jobs.pxu b/units/dock/jobs.pxu
2index 5368718..c457102 100644
3--- a/units/dock/jobs.pxu
4+++ b/units/dock/jobs.pxu
5@@ -398,7 +398,8 @@ _purpose:
6 (Skip this test if there is no headphone connector on the dock)
7 _steps:
8 1. Connect a pair of headphones to the dock
9- 2. Click the Test button to play a sound to your audio device
10+ 2. Go to the Sound settings and make sure the correct Output is selected
11+ 3. Click the Test button to play a sound to your audio device
12 _verification:
13 Did you hear a sound through the headphones and did the sound play without any distortion, clicks or other strange noises from your headphones?
14
15@@ -426,8 +427,9 @@ _purpose:
16 (Skip this test if the dock does not have a microphone connector)
17 _steps:
18 1. Connect a microphone to the dock's microphone port
19- 2. Click "Test", then speak into the external microphone
20- 3. After a few seconds, your speech will be played back to you
21+ 2. Go to the Sound settings and make sure the correct Output is selected
22+ 3. Click "Test", then speak into the external microphone
23+ 4. After a few seconds, your speech will be played back to you
24 _verification:
25 Did you hear your speech played back?
26
27diff --git a/units/dock/test-plan.pxu b/units/dock/test-plan.pxu
28index 7d21dfa..4c906ac 100644
29--- a/units/dock/test-plan.pxu
30+++ b/units/dock/test-plan.pxu
31@@ -45,9 +45,7 @@ include:
32 dock/audio-alsa-info-collect
33 dock/audio-alsa-info-attachment
34 dock/audio-list-devices
35- dock/audio-speaker-headphone-plug-detection certification-status=blocker
36 dock/audio-playback-headphones certification-status=blocker
37- dock/audio-microphone-plug-detection certification-status=blocker
38 dock/audio-alsa-record-playback-external certification-status=blocker
39 dock/audio-external-linein
40 dock/audio-external-lineout
41@@ -208,9 +206,7 @@ include:
42 dock/monitor_type-c_vga certification-status=blocker
43 dock/keys-video-out certification-status=blocker
44 dock/monitor-dual-head certification-status=blocker
45- dock/audio-speaker-headphone-plug-detection certification-status=blocker
46 dock/audio-playback-headphones certification-status=blocker
47- dock/audio-microphone-plug-detection certification-status=blocker
48 dock/audio-alsa-record-playback-external certification-status=blocker
49 dock/networking-gateway-ping certification-status=blocker
50 dock/networking-ntp certification-status=blocker
51diff --git a/units/keys/jobs.pxu b/units/keys/jobs.pxu
52index 4402b4c..4217db5 100644
53--- a/units/keys/jobs.pxu
54+++ b/units/keys/jobs.pxu
55@@ -277,3 +277,15 @@ _description:
56 VERIFICATION:
57 Did the keyboard overhead light key or switch turns on and off the light?
58
59+plugin: manual
60+category_id: com.canonical.plainbox::keys
61+id: keys/power-button
62+estimated_duration: 30.0
63+flags: also-after-suspend-manual
64+_purpose:
65+ This test will test the power button
66+_steps:
67+ 1. press the power button.
68+ 2. press cancel to quit.
69+_verification:
70+ Did the power management prompt pop up when press power button?
71diff --git a/units/keys/test-plan.pxu b/units/keys/test-plan.pxu
72index 38386ef..87b7fbc 100644
73--- a/units/keys/test-plan.pxu
74+++ b/units/keys/test-plan.pxu
75@@ -24,6 +24,7 @@ include:
76 keys/wireless certification-status=blocker
77 keys/keyboard-backlight certification-status=blocker
78 keys/microphone-mute certification-status=blocker
79+ keys/power-button certification-status=blocker
80
81 id: keys-cert-automated
82 unit: test plan

Subscribers

People subscribed via source and target branches