Merge ~gabrielcocenza/charm-prometheus-alertmanager:charm-snap into charm-prometheus-alertmanager:master

Proposed by Gabriel Cocenza
Status: Merged
Approved by: Eric Chen
Approved revision: 55604f5a0d80b5afff6ada5442ee9376345c68bd
Merged at revision: 48dacf60e12a191d5eaa9535f1feaa162e43d1fe
Proposed branch: ~gabrielcocenza/charm-prometheus-alertmanager:charm-snap
Merge into: charm-prometheus-alertmanager:master
Diff against target: 15 lines (+3/-1)
1 file modified
charmcraft.yaml (+3/-1)
Reviewer Review Type Date Requested Status
Eric Chen Approve
Erhan Sunar (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
Review via email: mp+442375@code.launchpad.net

Commit message

Pin charm snap version as a temporary fix.

- build start failing because of a incompatibility issue with
  charmcraft and charm snap.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Erhan Sunar (esunar) wrote :

LGTM

review: Approve
Revision history for this message
Eric Chen (eric-chen) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 48dacf60e12a191d5eaa9535f1feaa162e43d1fe

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charmcraft.yaml b/charmcraft.yaml
2index 1f750bc..3332b64 100644
3--- a/charmcraft.yaml
4+++ b/charmcraft.yaml
5@@ -3,7 +3,9 @@ parts:
6 charm:
7 source: src
8 plugin: reactive
9- build-snaps: [charm]
10+ build-snaps: [ charm/2.x/stable ] # charmcraft has incompatibility issue
11+ # with the latest charm snap. Pining the
12+ # version to 2.x/stable as a temporary fix
13 bases:
14 - build-on:
15 - name: ubuntu

Subscribers

People subscribed via source and target branches

to all changes: