~gabrielcocenza/charm-juju-lint:bug/1993334

Branch merges

Propose for merging

Merged into charm-juju-lint:master at revision 89392d23f89b265235937a6dc4236f6f1deb9e16

Mert Kirpici (community): Approve on 2022-11-02

Erhan Sunar (community): Approve on 2022-10-31

🤖 prod-jenkaas-bootstack: Approve (continuous-integration) on 2022-10-21

BootStack Reviewers: Pending requested 2022-10-20

Diff: 162 lines (+51/-13)

4 files modified

lib/lib_jujulint.py (+15/-6)
scripts/templates/auto_lint.py (+2/-2)
tests/unit/test_auto_lint.py (+4/-4)
tests/unit/test_charm.py (+30/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

40c6b01... by Gabriel Cocenza on 2022-10-20

add timeout for running auto_lint.py

- hook enter into error state instead of holding machine lock
- change juju loop(deprecated) to jasyncio

Closes-Bug: #1993334

e83a021... by Mert Kirpici on 2022-09-16

Close LP #1987367

Reviewed-on: https://code.launchpad.net/~mertkirpici/charm-juju-lint/+git/charm-juju-lint/+merge/429478
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: Sudeep Bhandari <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>

4f44212... by Mert Kirpici on 2022-09-16

charmcraft: add comment for multiple builds

Signed-off-by: Mert Kırpıcı <email address hidden>

39e6aef... by Mert Kirpici on 2022-09-16

build: add comments to charmcraft and README

Signed-off-by: Mert Kırpıcı <email address hidden>

8f39202... by Mert Kirpici on 2022-09-16

tests/functional: update juju-local charm

charm-juju-local is moved under a new name in charmhub. Accomodate that
change here.

See: LP #1989554

Signed-off-by: Mert Kırpıcı <email address hidden>

4f61759... by Mert Kirpici on 2022-09-02

build: add jammy support

snapcraft>1.4.0 builds python packages listed under
`charm-python-packages` from source during build time[0], creating
platform dependence for compiled components of libraries like bcrypt and
cryptography which are required as dependencies of paramiko. This
behavior ends up having ABI incompatibilities when packages are built
and run in different ubuntu series, which is sometimes surfacing as a
GLIBC soversion problem during runtime. In order to eliminate that we
are allowing installation of prebuilt wheel for paramiko using
`charm-binary-python-packages`, since it is supported on multiple
platforms much better. Also we no longer need the whole rust toolchain
and ffi headers, so they are removed as well.

Also we are now producing 2 charms since the installed websockets
library during build time drops support for either python3.10(jammy) or
python3.6(bionic) depending on the build environment. See libjuju's
dependencies[1] and websockets changelog[2].

[0] https://github.com/canonical/charmcraft/releases/tag/1.4.0
[1] https://github.com/juju/python-libjuju/blob/3.0.1/setup.py#L38
[2]
https://websockets.readthedocs.io/en/stable/project/changelog.html#id8

Closes-Bug: 1987367
Signed-off-by: Mert Kırpıcı <email address hidden>

0197b12... by Przemyslaw Lal on 2022-04-28

Rewrite auto_lint.py when creating it from the template

Reviewed-on: https://code.launchpad.net/~przemeklal/charm-juju-lint/+git/charm-juju-lint/+merge/420741
Reviewed-by: Xav Paice <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>

8f8ec04... by Przemyslaw Lal on 2022-04-28

Rewrite auto_lint.py when creating it from the template

Fixes LP: #1970753

Signed-off-by: Przemyslaw Lal <email address hidden>

7f43938... by Xav Paice on 2022-04-28

add charmcraft.yaml

Reviewed-on: https://code.launchpad.net/~xavpaice/charm-juju-lint/+git/charm-juju-lint/+merge/417016
Reviewed-by: Przemysław Lal <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>

dc86a25... by Xav Paice on 2022-04-28

pin typing-extensions for Python 3.6 support