Merge ~gabrielcocenza/charm-hw-health:charm-snap into charm-hw-health:master

[Gabriel Cocenza]

Pin charm snap version as a temporary fix.

- build start failing because of a incompatibility issue with
charmcraft and charm snap.

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack)]

PASSED: Continuous integration, rev:4572c4a9af66b44fc0afee3d21b6fd21d95fcfa2
https://jenkins.canonical.com/bootstack/job/lp-charm-hw-health-ci/4/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-unit/15/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/255/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-hw-health-ci/4//rebuild

review: Approve (continuous-integration)

[Eric Chen (eric-chen)]

Why we didn't encounter this issue 2 weeks before and we already had 23.04 release?

review: Needs Information

[Gabriel Cocenza (gabrielcocenza)]

I'm also very suprised that this error didn't show up before.

I didn't investigate the deep details why this didn't happen 2 weeks ago, but the facts are:

- it's failing to build on launchpad[0] and also on my local machine (it wasn't some days ago).
- the logs[1] show that it's a C dependency issue (lines 1509-1514):
- we already faced that before in other reactive charms using charmcraft.yaml (charm-telegraf [2])
- strangely, just the latest/stable release of the snap `charm`[3] got updated recently (6 April 2023)
- setting the dependency to 3.x/stable didn't fix.
- setting the dependency to 2x/stable fix it.

[0] https://launchpadlibrarian.net/664448358/buildlog_charm_ubuntu_jammy_amd64_daily_BUILDING.txt.gz
[1] https://pastebin.canonical.com/p/Z7bmn9xtXK/
[2] https://chat.canonical.com/canonical/pl/otwweyx5pbb6b8cbngowzzyg4h
[3] https://snapcraft.io/charm

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision 415897cb37eb5e74cc13b9e9de16676f70280582

diff --git a/charmcraft.yaml b/charmcraft.yaml
index 9c68524..0fd1504 100644
--- a/charmcraft.yaml
+++ b/charmcraft.yaml
@@ -3,7 +3,9 @@ parts:
   charm:
     source: src
     plugin: reactive
-    build-snaps: [charm]
+    build-snaps: [ charm/2.x/stable ] # charmcraft has incompatibility issue
+                                      # with the latest charm snap. Pining the
+                                      # version to 2.x/stable as a temporary fix
 bases:
     - build-on:
         - name: ubuntu