Code review comment for lp:~gabriel-samfira/python-tx-tftp/python-tx-tftp

Revision history for this message
Gavin Panella (allenap) wrote :

I wonder why it was set to 1400. It's close to the typical Ethernet LAN MTU of 1500, so I wonder if there's a reason for this setting, but this might well be a coincidence too. The upstream maintainer and original author is, and the upstream branch is It's worth making a pull request out of this change and see what he/she thinks. Ultimately we'd want to get this change upstream anyway.

Another question: is TFTP really a good choice for moving files of ~270MB across a network, or are you forced to do this? I suspect a TCP-based mechanism, HTTP perhaps, would be quicker and possibly more reliable.

review: Needs Information

« Back to merge proposal