Merge lp:~gabipetrovay/zorba/two-expected-failures into lp:zorba

Proposed by Gabriel Petrovay
Status: Merged
Approved by: Gabriel Petrovay
Approved revision: 10498
Merged at revision: 10499
Proposed branch: lp:~gabipetrovay/zorba/two-expected-failures
Merge into: lp:zorba
Diff against target: 86 lines (+31/-13)
3 files modified
cmake_modules/Windows/FindCURL.cmake (+23/-8)
cmake_modules/Windows/ProxyFindModule.cmake (+2/-2)
test/rbkt/Queries/CMakeLists.txt (+6/-3)
To merge this branch: bzr merge lp:~gabipetrovay/zorba/two-expected-failures
Reviewer Review Type Date Requested Status
Gabriel Petrovay (community) Approve
Review via email: mp+78741@code.launchpad.net

Commit message

Marked two core tests failing on Windows as expected failures.

Description of the change

Two core tests are failing on Windows. I have created one bug for each:

https://bugs.launchpad.net/zorba/+bug/871061 - test/rbkt/zorba/versioning/link1
https://bugs.launchpad.net/zorba/+bug/871062 - test/rbkt/zorba/xqdoc/moduleDocumentation

To post a comment you must log in.
Revision history for this message
Gabriel Petrovay (gabipetrovay) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job two-expected-failures-2011-10-09T01-14-06.746Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake_modules/Windows/FindCURL.cmake'
2--- cmake_modules/Windows/FindCURL.cmake 2011-09-26 12:50:56 +0000
3+++ cmake_modules/Windows/FindCURL.cmake 2011-10-09 01:13:29 +0000
4@@ -31,13 +31,28 @@
5
6 IF (CURL_FOUND)
7
8- # find the needed DLL's
9- FIND_PACKAGE_DLL_WIN32 (${FOUND_LOCATION} "libcurl" "curllib")
10- FIND_PACKAGE_DLL_WIN32 (${FOUND_LOCATION} "libeay32")
11- FIND_PACKAGE_DLL_WIN32 (${FOUND_LOCATION} "openldap")
12- FIND_PACKAGE_DLL_WIN32 (${FOUND_LOCATION} "ssleay32")
13-
14- # find additional DLL's
15- FIND_DLL_WIN32 (libsasl.dll)
16+ IF (EXISTS "${FOUND_LOCATION}/curl.exe")
17+
18+ MESSAGE (STATUS "Found CURL binary distribution")
19+
20+ # find the needed DLL's
21+ FIND_PACKAGE_DLL_WIN32 (${FOUND_LOCATION} "libcurl" "curllib")
22+ FIND_PACKAGE_DLL_WIN32 (${FOUND_LOCATION} "libeay32")
23+ FIND_PACKAGE_DLL_WIN32 (${FOUND_LOCATION} "openldap")
24+ FIND_PACKAGE_DLL_WIN32 (${FOUND_LOCATION} "ssleay32")
25+
26+ ELSE (EXISTS "${FOUND_LOCATION}/curl.exe")
27+
28+ MESSAGE (STATUS "Found CURL source build")
29+
30+ # find the needed DLL's
31+ FIND_PACKAGE_DLL_WIN32 (${FOUND_LOCATION} "libcurl" "curllib")
32+
33+ # find additional DLL's
34+ FIND_DLL_WIN32 ("libeay32.dll")
35+ FIND_DLL_WIN32 ("ssleay32.dll")
36+ #FIND_DLL_WIN32 (libsasl.dll)
37+
38+ ENDIF (EXISTS "${FOUND_LOCATION}/curl.exe")
39
40 ENDIF (CURL_FOUND)
41
42=== modified file 'cmake_modules/Windows/ProxyFindModule.cmake'
43--- cmake_modules/Windows/ProxyFindModule.cmake 2011-10-05 20:22:04 +0000
44+++ cmake_modules/Windows/ProxyFindModule.cmake 2011-10-09 01:13:29 +0000
45@@ -243,7 +243,7 @@
46 TMP_DLL_VAR
47 "${NAME}.dll"
48 PATHS "${LIBRARY_LOCATION}"
49- PATH_SUFFIXES "bin" "bin/Release"
50+ PATH_SUFFIXES "bin" "bin/Release" "lib"
51 NO_DEFAULT_PATH
52 )
53
54@@ -308,7 +308,7 @@
55 TMP_DLL_VAR
56 "${NAME}"
57 PATHS "${LIBRARY_LOCATION}"
58- PATH_SUFFIXES "bin" "bin/Release"
59+ PATH_SUFFIXES "bin" "bin/Release" "lib"
60 NO_DEFAULT_PATH
61 )
62
63
64=== modified file 'test/rbkt/Queries/CMakeLists.txt'
65--- test/rbkt/Queries/CMakeLists.txt 2011-09-12 23:22:24 +0000
66+++ test/rbkt/Queries/CMakeLists.txt 2011-10-09 01:13:29 +0000
67@@ -246,7 +246,12 @@
68 ENDIF(XVERMAJ EQUAL 2)
69
70 IF(WIN32)
71- EXPECTED_FAILURE(test/rbkt/zorba/eval/eval_schema2 3137594)
72+ EXPECTED_FAILURE(test/rbkt/zorba/versioning/external1 870991)
73+ EXPECTED_FAILURE(test/rbkt/zorba/versioning/external2 870991)
74+
75+ EXPECTED_FAILURE(test/rbkt/zorba/versioning/link1 871061)
76+ EXPECTED_FAILURE(test/rbkt/zorba/xqdoc/moduleDocumentation 871062)
77+
78 EXPECTED_FAILURE(test/rbkt/zorba/file/createWriteReadDeleteSeries 3276394)
79 ENDIF(WIN32)
80
81@@ -268,5 +273,3 @@
82
83 EXPECTED_FAILURE(test/rbkt/zorba/http-client/put/put3_binary_element 3391756)
84 EXPECTED_FAILURE(test/rbkt/zorba/http-client/post/post3_binary_element 3391756)
85-
86-# vim:set et sw=2 ts=2:

Subscribers

People subscribed via source and target branches