Merge ~fwieffering/maas:tgt-redfish-bugfix into maas:master
Status: | Merged |
---|---|
Approved by: | Blake Rouse |
Approved revision: | 1c395302c2e11011fd5f66702a7d122a3e2a6e5c |
Merge reported by: | MAAS Lander |
Merged at revision: | not available |
Proposed branch: | ~fwieffering/maas:tgt-redfish-bugfix |
Merge into: | maas:master |
Diff against target: |
252 lines (+114/-15) 4 files modified
src/maasserver/api/nodes.py (+1/-1) src/maasserver/clusterrpc/power.py (+1/-1) src/provisioningserver/drivers/power/redfish.py (+34/-12) src/provisioningserver/drivers/power/tests/test_redfish.py (+78/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Blake Rouse (community) | Approve | ||
MAAS Lander | Approve | ||
Review via email: mp+373131@code.launchpad.net |
Commit message
Fixes LP: #1845032 - Fixes issues that causes MAAS Redfish power driver to not work on some BMC's.
* removed trailing slashes from redfish power driver. This caused errors for some manufacturers implementations that we use
* catch json parsing errors and return a sensible error message if it fails to parse
* increase timeout on power query calls
* check state in redfish power driver power_off prior to submitting power_off request. Some redfish implementations we encountered errors if the state was already off and a power off request was submitted
Description of the change
We have switched to the redfish power driver for MaaS and encountered a few bugs that we needed to fix.
- removed trailing slashes from redfish power driver. This caused errors for some manufacturers implementations that we use
- catch json parsing errors and return a sensible error message if it fails to parse
- increase timeout on power query calls
- check state in redfish power driver power_off prior to submitting power_off request. Some redfish implementations we encountered errors if the state was already off and a power off request was submitted
Will comment with branch once bug is created
UNIT TESTS
-b tgt-redfish-bugfix lp:~fwieffering/maas/+git/maas into -b master lp:~maas-committers/maas
STATUS: FAILED maas-ci- jenkins. internal: 8080/job/ maas/job/ branch- tester/ 6476/console 27e6a387aa010f4 89c469dac0
LOG: http://
COMMIT: 18bdccb5235e69f