Code review comment for lp:~fwereade/pyjuju/webdav-unicode-paths

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

I'm not entirely sure this is the right thing to do.

[1]

A few questions:

- Shouldn't this be URL-encoding the string, rather than simply encoding into UTF-8?

- What happens if the URL actually contains non-ASCII characters? Will EC2/Orchestra explode?

review: Needs Information

« Back to merge proposal