lp:~fwereade/juju-core/watch-containers-alternative

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1287. By William Reade on 2013-06-17

alternative WatchContainers implementation

1286. By Tim Penhey on 2013-06-17

[r=thumper] Add lxc to our cloud-init packages

However don't add lxc if the machine itself is an
lxc container as the install fails on precise causing
the lxc container to fail to start.

https://codereview.appspot.com/10235047/

1285. By Tim Penhey on 2013-06-16

[r=thumper] Add a MachineIdFromTag function.

There are times (coming in future branches) where you want to be able to
reverse the MachineTag result back into a machineId.

https://codereview.appspot.com/10274044/

1284. By Tim Penhey on 2013-06-16

[r=thumper] Move environs.Instance into own package.

Instances are the realizations of state Machines, and could
be either containers or environ provider instances.

https://codereview.appspot.com/10273044/

1283. By Madison Scott-Clary on 2013-06-16

[r=wallyworld] Juju status supports containers

juju status shows containers nested against their parent machine.
The machine id less than function needed to be updated to support
container ids. A drive by additional test for adding containers
to an injected machine is also included.

https://codereview.appspot.com/10252044/

1282. By Данило Шеган on 2013-06-16

[r=jameinel],[bug=1190560] Ignore Emacs auto-save files in lbox pre-checks

Emacs auto-save files are named '.#...', so if you have a storage.go file open, Emacs will keep a '.#storage.go' file around for auto-saving. However, the way we pass arguments to gofmt means that '.#' will not be properly escaped and gofmt will not be able to open the file, thus stopping an lbox propose.

This change removes any filenames beginning with '.#' with a simple grep.

https://codereview.appspot.com/10244044/

1281. By Tim Penhey on 2013-06-16

[r=jameinel] Fix the cmd/juju tests.

One of the tests was emitting an error, but the suite wasn't
a logging suite, so it was being output to stderr.

Also, there was a file called 2 created in the directory. This
was due to an echo >2 line in a plugin test script. This was
wrong anyway, we don't emit missing description as it fails other
tests. This has been removed.

https://codereview.appspot.com/10253053/

1280. By Frank Mueller on 2013-06-14

[r=jameinel] cleaner: implemented the cleaner worker

The cleaner worker listens to events raised by
the cleaner watcher. This signals that there are documents
marked for removal. So the worker calls state.Cleanup()
to remove them.

https://codereview.appspot.com/10148045/

1279. By John A Meinel on 2013-06-13

[r=jameinel] cmd/juju: Make a test deterministic

TestGatherDescriptionsInParallel was timing dependent, and occasionally failed on my system. Rather than just increasing the timeout arbitrarily, I changed the code to be more 'event' based. Each plugin requires another plugin to have started before that plugin will return. Thus, if we don't start the plugins in parallel, the plugin will deadlock.

Because the failure mode is 'deadlock', I wrapped the call in a select timeout. This means that if it *does* fail, we have a garbage goroutine and process lying around (but it should never fail).

On the plus side, this makes it actually run faster, since each subprocess
doesn't waste time sleeping just so we can measure it. (from 350ms down to normally around 15ms.)

This is the only test that was failing (based on occasional timing hiccups) for me, which allows us to have this in tarmac.

1278. By Tim Penhey on 2013-06-13

Update the validMachine regex for containers

Yay regex.

R=wallyworld, fwereade
CC=
https://codereview.appspot.com/10215043