lp:~fwereade/juju-core/trivial-new-unit-test-charms

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:~juju/juju-core/trunk

The Go Language Gophers: Pending requested 2012-10-30

Diff: 50 lines (+18/-0)

6 files modified

testing/repo/series/rel-peer/metadata.yaml (+5/-0)
testing/repo/series/rel-peer/revision (+1/-0)
testing/repo/series/rel-pro/metadata.yaml (+5/-0)
testing/repo/series/rel-pro/revision (+1/-0)
testing/repo/series/rel-req/metadata.yaml (+5/-0)
testing/repo/series/rel-req/revision (+1/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

699. By William Reade on 2012-10-30

add test charms to allow future relationy unit tests to add verified relations to services

698. By Dave Cheney on 2012-10-30

worker/provisioner: fix race on config reload

Bug #1064144 was cause by a race between the PA reloading it's config -or-
observing a change to the machines collection. This proposal adds an observer
that the tests can use to wait until the PA has ack'd the configuration
change.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6742049

697. By William Reade on 2012-10-30

state: drop obsolete relation lifecycle

drop:

* Relation.EnsureDying
* Relation.EnsureDead
* State.RemoveRelation

...and use Relation.Destroy and RelationUnit.LeaveScope instead throughout.

R=niemeyer
CC=
https://codereview.appspot.com/6812047

696. By William Reade on 2012-10-30

state: Relation.Destroy

...and `juju remove-relation`, because it's trivial now that Destroy exists.

Points to note:

* Relation.EnsureDying, Relation.EnsureDead, and State.RemoveRelation are
  now obsolete, and will be remove entirely in a followup CL; omitted here
  due to volume of change.
* It's still called remove-relation, instead of destroy-relation + alias,
  because it seems more sensible to fix remove-unit at the same time and it
  also deserves a separate CL IMO.

R=niemeyer
CC=
https://codereview.appspot.com/6783051

695. By Roger Peppe on 2012-10-30

worker/uniter: make logger predictable

The stdout pipe is closed too early by os/exec;
do the work ourselves to prevent this.

R=dfc, niemeyer
CC=
https://codereview.appspot.com/6774050

694. By William Reade on 2012-10-29

juju:implement add-relation

R=niemeyer
CC=
https://codereview.appspot.com/6761044

693. By William Reade on 2012-10-29

upstart: use better Out value

We now use the same value for upstart conf Out fields as we do --log-file
params. No idea what I did to lead myself to think it didn't work...

Also, made log file names more consistent (ie $kind-$name.log, with no
explicit "-agent")

R=rog, niemeyer
CC=
https://codereview.appspot.com/6766051

692. By William Reade on 2012-10-29

uniter/charm: verify upgrade symlink overwrite

Verifies non-existence of lp:988115 in juju-core

R=niemeyer
CC=
https://codereview.appspot.com/6760046

691. By Frank Mueller on 2012-10-29

firewaller: integrated global mode

Firewaller now recognizes the global mode. It dies a
port usage counting usage counting and opens each
used port only once and closes it after the last using unit
has gone. The handling of ports in case of a restart has
been removed from this CL to a later one.

R=
CC=
https://codereview.appspot.com/6713054

690. By Roger Peppe on 2012-10-26

cmd/builddb: fix ssl build

Also add a couple of log messages.

R=fwereade, dfc
CC=
https://codereview.appspot.com/6776051