lp:~fwereade/juju-core/strawman-state-test-simplification

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:~juju/juju-core/trunk

The Go Language Gophers: Pending requested 2012-12-06

Diff: 897 lines (+306/-361)

4 files modified

state/assign_test.go (+203/-353)
state/conn_test.go (+92/-0)
state/life_test.go (+1/-1)
state/unit.go (+10/-7)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

768. By William Reade on 2012-12-06

tighten up AssignSuite using new additions to ConnSuite

767. By Ian Booth on 2012-12-05

Add more OpenStack provider implementation

This branch starts with the initial stub OpenStack provider and fleshes out more infrastructure and code. Initial impementations of Environ methods
Instances() and AllInstances() are done, as well as a bunch more boilerplate to glue in the provider config etc.

The relevant goose library APIs are used to access a live Canonistack instance. For the purpose of the live tests, test server instances are create and destroyed. At the
moment, a knowm image is used to create the servers.

There is at least one limitation in the underlying goose nova client which needs to be addressed - the ability to filter the results returned by ListServers(). This
is required to exclude deleted and other irrelevant servers from AllInstances() but there is no support yet for this in goose.

I've also restructured the initial tests to hook into the juju test infrastructure so that the standard juju tests are run with this OpenStack provider. Of course,
they currently fail but will pass as soon as all of the provider methods are done. I've also included individual tests for each implemented API in the provider's
live test module. These compliment the juju tests which in this case appear more integration rather than unit focussed.

R=niemeyer
CC=
https://codereview.appspot.com/6874049

766. By Dave Cheney on 2012-12-03

version: set development version to 1.9.4

R=
CC=
https://codereview.appspot.com/6869047

765. By Dave Cheney on 2012-11-30

environs/ec2: specify public-bucket-region

Fixes LP #1083017

Our public bucket, juju-dist, lives in the us-east-1 region and can only be accessed via that endpoint. If you attempt to do so via another endpoint you get an unhelpful 301 error with an xml blob telling you how to request the bucket. The solution is to add a configuration option, with sensible default, to ec2/config.go to specify the region of the public bucket independantly of the private bucket.

R=jameinel, niemeyer
CC=
https://codereview.appspot.com/6854098

764. By William Reade on 2012-11-30

firewaller: skip flaky test

Note that the test itself is bascially fine; it exposes problems with the
firewaller initialization, which need to be addressed, but which would
respond well to expert attention.

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6849126

763. By William Reade on 2012-11-30

state: UnitsWatcher always reports dead units

...instead of skipping them in the initial event, which is not helpful
behaviour.

R=niemeyer
CC=
https://codereview.appspot.com/6846133

762. By William Reade on 2012-11-30

firewaller: use new style machine units watcher

After https://code.launchpad.net/%7Earamh/juju-core/120-firewaller-new-watcher-units7/+merge/133269

Addresses comments made at https://codereview.appspot.com/6820112/

R=niemeyer
CC=
https://codereview.appspot.com/6843128

761. By William Reade on 2012-11-30

state: MachineUnitsWatcher unwatches correct units

This means that stopped MUWs no longer end up blocking the watcher. To help
detect problems like this more easily in future, the watcher package now
panics when unwatching an unknown key.

And I fixed RelationScopeWatcher, which was using the old'n'busted double-
loop style, and replaced "changeChan"s with "out"s for those watchers that
I expect to continue to exist (ie not MachinePrincipalUnitsWatcher). Sorry,
I couldn't resist.

R=ricky.kernberger
CC=
https://codereview.appspot.com/6856122

760. By Roger Peppe on 2012-11-29

various: use TLS

This enables TLS for everything.

R=fwereade, jameinel, niemeyer
CC=
https://codereview.appspot.com/6856105

759. By Roger Peppe on 2012-11-29

environs/jujutest: fix test

LiveTests.TestStartStop did not work when called
with an already-bootstrapped environment.
Coincidentally, LiveTests.TestDestroy was
always called after the only other test to bootstrap,
so running all the tests worked.

R=TheMue, gz
CC=
https://codereview.appspot.com/6850121