Color for blue is not in this PR, but to make it easier to see is in the picture.
I have also spoken with a few, where they feel more may still be warranted to make this stand out so open for options/feedback for us to update this more.
Closes #2786
ACKs for top commit:
Fuzzbawls:
ACK 2543f6b99bb017fa7ed333a7284b4d99826a82cd
panleone:
tACK 2543f6b99bb017fa7ed333a7284b4d99826a82cd
We previously discussed fixing the `fetch-params.sh` script, but after discussion its not actually used and is redundant.
This script is broken and `install-params.sh` works fine, so lets just remove it.
ACKs for top commit:
Fuzzbawls:
ACK 2c73d25f8fa080344ee34380ae8c965a45676e82
panleone:
utACK 2c73d25f8fa080344ee34380ae8c965a45676e82
Merge #2872: [Depends] Bump Rust toolchain to 1.69.0
1bc92be0309e27393fba0eb2a40812a4e3be9f84 Depends: Bump rust toolchain to v1.69.0 (Fuzzbawls)
5708543d1acb00cd5f2ac83b9423781bafc19541 Scripts: Bump minimum supported glibc to v2.27 (Fuzzbawls)
f2cfadbba39fb2f854947c6712def612959135aa GA: Run security-check on depends based builds (Fuzzbawls)
0a27b1612d400505cd1b4e2e4598be3819aea907 GA: Run symbol-check on depends based builds (Fuzzbawls)
02b7cb9a096e6c1ee25801a452fd46e720cd37b1 scripts: add PE dylib checking to symbol-check.py (fanquake)
ee3bdc6ed6d51498e0aa21ca5d29c5062b9b5683 depends: build gmp with PIC on all platforms (Fuzzbawls)
85d1632117b5078f1b8e4601e0a115171d1aa0cd scripts: add MACHO dylib checking to symbol-check.py (fanquake)
c2facf0b47b7a6f21358b7d6d3f4578c4cbbd81b scripts: fix check-symbols & check-security argument passing (fanquake)
3af2b2fa1eb9b82c8c82b50936726372a1dd7207 scripts: add MACHO NOUNDEFS check to security-check.py (fanquake)
83f86c358d43e0fe1d05ead41e793482519f90f7 scripts: add MACHO PIE check to security-check.py (fanquake)
Pull request description:
Alternative to #2871.
This bumps our Rust Toolchain to v1.69.0, but comes at the cost of ALSO bumping our minimum supported linux glibc to 2.27, which officially drops support for Ubuntu 16.04, Debian 8 (Jessie), Debian 9 (Stretch), and CentOS 7 for binary releases.
Ubuntu 16.04 and CentOS 7 technically don't reach EOL (End Of Life) until 2024, but both are largely unsupported in linux communities already.
The major benefit to this outside of being able to use a more recent Rust toolchain version, is that it allows us to use the official Rust distribution toolchains and no longer maintain our own modified versions, a significant time saver if this ability is carried forward in the future.
ACKs for top commit:
Duddino:
tACK 1bc92be0309e27393fba0eb2a40812a4e3be9f84, works fine with #2870
panleone:
tACK 1bc92be0309e27393fba0eb2a40812a4e3be9f84