~fuzzbawls/pivx-core/+git/test:2023_depends-zlib-bump

Branch merges

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

5966c9e... by Fuzzbawls on 2023-03-28

[Depends] Bump zlib to v1.2.13

523877c... by Fuzzbawls on 2023-03-24

Merge #2821: [Build] Disable libsep256k1's openssl tests

7547b3007f78adc6df02d4a57d4b4c8c44eb6024 [Build] Disable libsep256k1's openssl tests (Fuzzbawls)

Pull request description:

  Systems that have OpenSSL 3.x installed cause the lib's openssl based tests to fail. We don't use OpenSSL in PIVX anymore, so these tests are not of much interest.

  Ref: https://github.com/bitcoin/bitcoin/pull/23314

ACKs for top commit:
  panleone:
    tACK 7547b3007f78adc6df02d4a57d4b4c8c44eb6024
  Liquid369:
    tACK 7547b3007f78adc6df02d4a57d4b4c8c44eb6024

Tree-SHA512: 7bc5fe16286946a851c81191ac07077f837515ff7055fe85cb77c48f92d7b1e73281f1034557184d5b07b7e61d218aa1ee55e48e5d6f6cc21f74033a85d85a5a

e4634a5... by Fuzzbawls on 2023-03-13

Merge #2806: [Tools] Sanitize existing clang-format rules

472a4236642185172c42173f7fa8db79e0a66536 Sanitize existing clang-format rules (Fuzzbawls)

Pull request description:

  Removes un-necessary extra whitespace, set explicit values instead of implied values for some rules, and update the standard to c++14.

  Updated the following rules to their new names:
  - `AlignEscapedNewlinesLeft` -> `AlignEscapedNewlines`
  - `IndentFunctionDeclarationAfterType` -> `IndentWrappedFunctionNames`

  Removed the following rules as they are un-necessary:
  - `Penalty*`: since we don't enforce a line length
  - `TabWidth`: since we don't use tabs

ACKs for top commit:
  Liquid369:
    tACK 472a4236642185172c42173f7fa8db79e0a66536
  panleone:
    utACK 472a4236642185172c42173f7fa8db79e0a66536

Tree-SHA512: 539dd87c6c0965828132ad8110a151aa4679db8fdc6adc93f606239ad903b22606934e790a9689dfad568dffc15cbd17d260ad7d07c43dc4d59d1a94832b1982

6f2d9be... by Fuzzbawls on 2023-03-13

Merge #2809: [Tier Two] Pre dip7 upgrade

3007354b98f19683ae6b196bf8e44b37db1f9042 RPC: Add listquorums and getquoruminfo (Alessandro Rezzi)
747863c787db5eb70efbc7454d4d77282a5b7b76 Added quorum and quorum manager classes (Alessandro Rezzi)

Pull request description:

  Abstract:
  The aim of this PR is adding all the background needed to implement Signing Requests (dip7). Two new classes are added that will help: storing/fetching/make sure we are connected to the latest k quorums

ACKs for top commit:
  Liquid369:
    ACK 3007354b98f19683ae6b196bf8e44b37db1f9042
  Fuzzbawls:
    ACK 3007354b98f19683ae6b196bf8e44b37db1f9042

Tree-SHA512: fa210544441d9c9e513adb40030c8f0caa1d8b28d0e6ae9c65a369418484511531600c780885d10dab255c4e6523926b1eabf3c67c7a7c0eee87955cb490ac9f

7547b30... by Fuzzbawls on 2023-03-12

[Build] Disable libsep256k1's openssl tests

Systems that have OpenSSL 3.x installed cause the lib's openssl based
tests to fail. We don't use OpenSSL in PIVX anymore, so these tests are
not of much interest.

ac8a74d... by Fuzzbawls on 2023-03-08

Merge #2812: [Wallet] Fix AutoCombineDust and improve setautocombinethreshold

63488be61d48c66fba7c8fb78fddbe3ae309fbc9 Update functional test wallet_autocombine.py (Alessandro Rezzi)
e7437c9fb97f4a1bf1e15a9766873a0a1594eb21 Update functional test DeprecatedRpcTest (Alessandro Rezzi)
1c300a2bc9b44e3fc82d1b613ffc6903eb212b7d Remove deprecated autocombinerewards RPC command (Alessandro Rezzi)
9ea65d55a5e9ba89ddcdca0f98f3c5a59b82edde Fixed and improved setautocombinethreshold (Alessandro Rezzi)
66dbb2e96449cefeddc3d5f95dc18dac529f9ad2 Fixed current AutoCombineDust (Alessandro Rezzi)

Pull request description:

  AutoCombineDust has been bugged since an old PR see (https://github.com/PIVX-Project/PIVX/pull/953 https://github.com/PIVX-Project/PIVX/pull/518).

  To make an example of what's happening let's consider for simplicity nAutoCombineThreshold = 100 and let's say that the user has 2 UTXOs one of 90 PIVs and the other of 15 PIVs.

  With the current code of AutoCombineDust we will therefore try to send a total of 90+15 = 105 PIVs to ourself, more precisely to avoid the "Insufficient funds" the primary output will contain only the 90% =94.5 PIVs and the remaining 10% = 10.5 PIVs is used to pay fees + sent as a change to ourself. As you can see we end up with two new UTXOs, which are still both smaller than the threshold.

  This process is iterated block by block until we end up with a single UTXO which is smaller than the threshold, i.e in this example 5 PIVs will be burn in fees.

  Moreover the process of "checking all UTXOs at each block for each address of your wallet" can potentially consume a lot of resources especially if the user has a lot of small UTXOs, therefore I added a new parameter "frequency" which will check for dust every N blocks (where N is the value of frequency), and which is set by default at N = 30.

  Finally I removed the old autocombinerewards since it is deprecated and was planned to be removed in v6.0 (https://github.com/PIVX-Project/PIVX/blob/master/doc/release-notes.md)

ACKs for top commit:
  Fuzzbawls:
    ACK 63488be6
  Liquid369:
    tACK 63488be61d48c66fba7c8fb78fddbe3ae309fbc9

Tree-SHA512: b06046590d63399e4f579fbcd899f77346c0c5b8fd69613b60874f3920b2d776da97878a5794336c873012757ebef969467f4381441903231bf41c4d70c4635f

9240e15... by Fuzzbawls on 2023-03-08

Merge #2817: [GA] Bump GA linux workers to Ubuntu 20.04

6a5e58be7a82a518588f43ea7e509b6aea705e3c [GA] Bump GA linux workers to ubuntu-20.04 (Fuzzbawls)
ac6bf5a65348d0d34234485746cc63db09291fa9 [CMake] Update for Ubuntu 20.04 (Fuzzbawls)

Pull request description:

  This is the final (for now) PR needed to fully update our GA workers/actions to non-deprecated versions.

  Previous work was done in the following PRs:
  #2787
  #2807

ACKs for top commit:
  Liquid369:
    tACK 6a5e58be7a82a518588f43ea7e509b6aea705e3c
  panleone:
    utACK 6a5e58be7a82a518588f43ea7e509b6aea705e3c

Tree-SHA512: 11a18d6c87d1645e8ad79d8ba78b610cccdbdc628d83324cf9334382b4dd79f2d3b4f5310a826d21cde85cf3f99afe0bcc837a84df2ffdfc47e6da9db41c5f02

3007354... by Alessandro Rezzi <email address hidden> on 2023-03-07

RPC: Add listquorums and getquoruminfo

747863c... by Alessandro Rezzi <email address hidden> on 2023-02-16

Added quorum and quorum manager classes

8b98370... by Fuzzbawls on 2023-03-06

Merge #2266: [Cleanup] Use C++11 nullptr instead of NULL

58e254e2e734e561201794274b39490eb0d4ce33 scripted-diff: Use C++11 nullptr instead of NULL (Fuzzbawls)

Pull request description:

  Scripted diff to replace all `NULL` macros with the C++11 `nullptr` keyword

  ```bash
  -BEGIN VERIFY SCRIPT-
  sed -i 's/\<NULL\>/nullptr/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h src/qt/*/*.cpp src/qt/*/*.h src/qt/pivx/*/*.cpp src/qt/pivx/*/*.h src/wallet/*/*.cpp src/test/*/*.cpp src/wallet/*/*.h
  sed -i 's/Prefer nullptr, otherwise SAFECOOKIE./Prefer NULL, otherwise SAFECOOKIE./g' src/torcontrol.cpp
  sed -i 's/tor: Using nullptr authentication/tor: Using NULL authentication/g' src/torcontrol.cpp
  sed -i 's/METHODS=nullptr/METHODS=NULL/g' src/test/torcontrol_tests.cpp src/torcontrol.cpp
  sed -i 's/nullptr certificates/NULL certificates/g' src/qt/paymentserver.cpp
  sed -i 's/"nullptr"/"NULL"/g' src/torcontrol.cpp src/test/torcontrol_tests.cpp
  -END VERIFY SCRIPT-
  ```

ACKs for top commit:
  panleone:
    re-utACK 58e254e2e734e561201794274b39490eb0d4ce33
  Liquid369:
    tACK 58e254e2e734e561201794274b39490eb0d4ce33

Tree-SHA512: 53075944e94792680b49f731335e06fa241fc981d7d31628f53fceaedc30ae8c1f9c7c86eea9c7def475cd147a435b3ee52a81596da01d91b8766e32bc665637