~fuzzbawls/pivx-core/+git/test:2022_update-clang-format

Last commit made on 2023-02-12
Get this branch:
git clone -b 2022_update-clang-format https://git.launchpad.net/~fuzzbawls/pivx-core/+git/test

Branch merges

Branch information

Name:
2022_update-clang-format
Repository:
lp:~fuzzbawls/pivx-core/+git/test

Recent commits

472a423... by Fuzzbawls

Sanitize existing clang-format rules

Removes un-necessary extra whitespace, set explicit values instead of
implied values for some rules, and update the standard to c++14.

Updated the following rules to their new names:
- `AlignEscapedNewlinesLeft` -> `AlignEscapedNewlines`
- `IndentFunctionDeclarationAfterType` -> `IndentWrappedFunctionNames`

Removed the following rules as they are un-necessary:
- `Penalty*`: since we don't enforce a line length
- `TabWidth`: since we don't use tabs

0bd96c8... by Fuzzbawls

Merge #2782: Wallet: Fix stake split output count calculation

6e51d385e42f1bd3a556ad9318c78c9d9c0c081f exclude masternode payment from stake split calculation (PeterL73)

Pull request description:

  ## Issue being fixed #1571
  The UTXO value of a stake split is sometimes smaller then the stake split threshold
  The help description for `setstakesplitthreshold` states:
  ```
  This will set the stake-split threshold value.
  Whenever a successful stake is found, the stake amount is split across as many outputs
  (each with a value higher than the threshold) as possible.
  ```
  So you would not expect the value of the UTXOs to be lower then the threshold value
  This happens because the number of stake split outputs is calculated including the masternode payment
  An example (for testnet) with a UTXO with a value of 9992 and the stake split threshold set to 500:
  ```
  9992 + 10 (total block reward: 4 stake reward + 6 masternode payment) = 10002
  10002 / 500 = 20.004
  (int) 20.004 = 20
  ```
  However the staker only receives the stake reward (4) so the total amount after staking will be 9996 which is split across 20 UTXOs with a value of 499.8 each
  ## What was done
  The masternode payment is excluded from the stake split output count calculation
  ## How Has This Been Tested
  On testnet 2 UTXOs were made (9992 each) and the stake split threshold was set to 500
  The expected outcome would be a split across 19 UTXOs with a value of 526.1 each
  ```
  9992 + 4 (stake reward) = 9996
  9996 / 500 = 19.992
  (int) 19.992 = 19
  9996 / 19 = 526.1
  ```
  #### Before
  On stake 20 UTXOs, with a value of 499.8 each, were created
  https://testnet.rockdev.org/tx/b966ff04d35ecae596f0dfde3977862268995d63939af3ab90bb172b38c37f20
  #### After
  On stake 19 UTXOs, with a value of 526.1 each were created
  https://testnet.rockdev.org/tx/e80c79ad1ac41aa096b4613462be348e7a1a4a70755c4943087a83be8865de7a

ACKs for top commit:
  Liquid369:
    tACK 6e51d385e42f1bd3a556ad9318c78c9d9c0c081f
  Fuzzbawls:
    ACK 6e51d385e42f1bd3a556ad9318c78c9d9c0c081f

Tree-SHA512: a875c2074cd93136802b2cfcde9ba252ac12b7759657f8041e03e720216b864866297c3d9f9c0b7c03ab62173af23580ec0c6b950f40726fc232a0499e2629e4

5c55659... by Fuzzbawls

Merge #2789: Add Liquid369 gpg key

642779886bdd46d31e398e0777c6b2077caef029 Add Liquid369 gpg key (Liquid369)

Pull request description:

  Add Liquid369's gpg key to the gitian builders list

ACKs for top commit:
  Fuzzbawls:
    ACK 642779886bdd46d31e398e0777c6b2077caef029

Tree-SHA512: d00cb8b775dfda5a8bea4b7e7d26d3770d2f5227cf0418502eda101e7d21df2cbb5539181d5a1870569a60960fbbb403bf9f723275b7dbd99ef5e2058674d38d

e9c7303... by Fuzzbawls

Merge #2793: [Consensus] Set v5.5.0 superblock checkpoint block hash.

42310bfa8e6635c17f164cb5f56f8a7410a85350 [Consensus] Set v5.5.0 superblock checkpoint block hash. (Fuzzbawls)

Pull request description:

  Hard codes the correct block hash for the mainnet v5.5.0 superblock.

  A network fork occurred at this block. The forked chain expected **NO** proposal payouts whatsoever, when there was clearly MN consensus for proposal payouts. It was clear that the forked chain that didn't want any proposal payouts was "in the wrong" here, so this PR hard codes the proper block hash of the first superblock of this particular round, which **does** include the expected proposal payouts.

ACKs for top commit:
  JSKitty:
    utACK 42310bfa8e6635c17f164cb5f56f8a7410a85350
  Liquid369:
    uTACK 42310bfa8e6635c17f164cb5f56f8a7410a85350
  panleone:
    utACK 42310bfa8e6635c17f164cb5f56f8a7410a85350

Tree-SHA512: 91cdee7472c794ff8538329b382950f7907e74d79e60fb7c12f210a3ddcda1d2714623c43e855413f12629143d5e20fbc2dd0c85bd4ab710fa8f1747ec83118f

d3acaa0... by Fuzzbawls

Merge #2788: [Doc] Don't include dependency paths in Doxygen or Coverage

5b4f21430e432b36e2eb7437704c3089cc0befe4 [Doc] Don't include dependency paths in Doxygen or Coverage (Fuzzbawls)

Pull request description:

  In-tree dependency libraries don't need to be included in Doxygen or Coverage reports, as doing so only adds extra "fluff" with no real purpose.

ACKs for top commit:
  Liquid369:
    uTACK 5b4f21430e432b36e2eb7437704c3089cc0befe4
  panleone:
    utACK 5b4f21430e432b36e2eb7437704c3089cc0befe4

Tree-SHA512: 205792847b77462ab3949f3222906c28db0c6a8bd885fbc493772aeaaa974b725109bcfae5ea23697ab1a3ee90b1726531da87eb0af8ee5bb8cb3d249da71095

286c318... by Fuzzbawls

Merge #2787: [GA] Update depreciated actions

0fee41c9028bb7667285655c67e4438fee66f098 [CMake] Use proper language launcher define (Fuzzbawls)
c64a7661c83f24124d1ae49e254de9aff233d4c4 [GA] Use shorter ccache file names for wallet builds (Fuzzbawls)
c9ea6c7529dab5cb7df15f37d8acf925e1bf2951 [GA] Use environment files instead of deprecated set-output (Fuzzbawls)
0ee6397170bc235be7a06828a9081d1f2f00a899 [GA] update to cache v3 (Fuzzbawls)
90ffa4558a21e658b5d3b83f31d87b4965db23e9 [GA] update to setup-python v4 (Fuzzbawls)
1794daaaf656a9ef2061d67c5d7a498e5962a580 [GA] Update to checkout v3 (Fuzzbawls)

Pull request description:

  Node 12 actions have been depreciated. Update actions to use Node 16 based versions.
  Ref: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

  `save-state` and `set-output` have been depreciated. Update GA workflow to no longer use these functions.
  Ref: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

  Use shorter ccache cache identifiers

  Use explicit CMAKE language launcher variable names

ACKs for top commit:
  Liquid369:
    utACK 0fee41c9028bb7667285655c67e4438fee66f098
  panleone:
    uTACK 0fee41c9028bb7667285655c67e4438fee66f098

Tree-SHA512: 088232d292a4ef7e80353e4e8b9c6c0dba2a17b361376e199eb55f0f67d3e29e195babf3c89a3ee58407f44263832dba16d56c6aa888ea4e179655e832cefbad

42310bf... by Fuzzbawls

[Consensus] Set v5.5.0 superblock checkpoint block hash.

Hard codes the correct block hash for the mainnet v5.5.0 superblock.

6427798... by Liquid369 <email address hidden>

Add Liquid369 gpg key

5b4f214... by Fuzzbawls

[Doc] Don't include dependency paths in Doxygen or Coverage

In-tree dependency libraries don't need to be included in Doxygen or
Coverage reports, as doing so only adds extra "fluff" with no real
purpose.

3c63095... by Fuzzbawls

Merge #2784: [Consensus] Bump v5.5 activation height for mainnet

142c1374ccbdbd72c445868c26972d0d5ab082d8 [Consensus] Bump v5.5 activation height for mainnet (Fuzzbawls)

Pull request description:

  Gives more time for users to update given the holiday season. Mainnet activation height set to 3715200

ACKs for top commit:
  EricStanek:
    utACK 142c1374ccbdbd72c445868c26972d0d5ab082d8
  yenachar:
    utACK 142c1374ccbdbd72c445868c26972d0d5ab082d8
  PeterL73:
    utACK 142c1374ccbdbd72c445868c26972d0d5ab082d8

Tree-SHA512: c2f0acd81da57df37fc5a8ff0a569ef08374a939a536ded8ac0042d9c4112056701279addddadbf365710298ec52499bf1249cfaac270918f80cb48e499b71b4