~fuzzbawls/pivx-core/+git/test:2021_translations-cleanup

Last commit made on 2021-11-10
Get this branch:
git clone -b 2021_translations-cleanup https://git.launchpad.net/~fuzzbawls/pivx-core/+git/test

Branch merges

Branch information

Name:
2021_translations-cleanup
Repository:
lp:~fuzzbawls/pivx-core/+git/test

Recent commits

40f2f12... by Fuzzbawls

[GUI] Make translate

After the previous commits, net result is 3 new strings and 75 removed
strings

f436b71... by Fuzzbawls

Qt: Unify translated strings in export UI

Cleans up the CSV export UI to reduce the number of strings being
translated.

dc45153... by Fuzzbawls

Qt: Use current network's display unit in payment request UI

Stop translating the `PIV` string literal, and use the current network's
 display unit.

ac5e858... by Fuzzbawls

Qt: Don't use a string literal for custom fee PIV/kB label

This string can be generated dynamically and using the current network's
 display unit. `kB` is also universally accepted in most languages so no
  translation is needed.

1ac3c44... by Fuzzbawls

Qt: Stop translating other placeholder strings

d169aa2... by Fuzzbawls

Qt: Stop translating placeholder windowTitles

178b3bb... by furszy <email address hidden>

Merge #2628: [GUI] Periodic make translate

13e90f6c2899945f673f1c5aced9af2a072c1a9e [GUI] Periodic make translate (Fuzzbawls)

Pull request description:

  114 new translation strings, mostly coming from the new Governance UI

ACKs for top commit:
  furszy:
    utACK 13e90f6c2899945f673f1c5aced9af2a072c1a9e
  random-zebra:
    utACK 13e90f6c2899945f673f1c5aced9af2a072c1a9e

Tree-SHA512: 526a7a812b40766daed9031c83468d78b1a8bd21a82b24e67f271bdb9e4d76d7eb68875c1b33833f298708e16d4663a43bdc715416db9ceade39b6e2e8adb433

9c47a10... by furszy <email address hidden>

Merge #2585: [Test] Secondary chains acceptance test coverage

8c7dd6c0bb732404018889b622693becfb29b5d2 wallet: shuffle stakeable coins in regtest. (furszy)
b9b8475ffbc8b631c1b96c641e406bbfadf8971c Tests: add case for coins created in G and G3, being spent in H and H3. Reorg test and case for coinstake on different chains (furszy)
242260bdec024d84d34f4eaf17b5a2c58b2e93f5 Tests: add block acceptance test cases for (1) coins created in D and spent in E3 and (2) coins create in D, spent in F and then double spent in F3 (furszy)
663f2a67acbec4e3f5816ee6f8d3d70651f8c5e0 [Wallet] Implement simple function to pre-select and get tx outputs known by the wallet. (furszy)
32649a62e389804306a69fc460eaeef1854f17cd Test: add secondary chain branches acceptance cases. (furszy)
205bf9aefb46d668018f355e3cfdaa3b058dd1c5 Refactor: Decouple stop condition from the PoS kernel solving process loop. (furszy)

Pull request description:

  ```
  Chains diagram:

  A -- B -- C -- D -- E -- F -- G -- H
             \
               -- D1 -- E1 -- F1
             \
               -- D2 -- E2 -- F2
             \
               -- D3 -- E3 -- F3 -- G3 -- H3
             \
               -- D4 -- E4 -- F4
  ```

  Coverage added on this work:
  1) coins created in D1 and spent in E1. --> expected result: pass.
  2) coins created in E, being spent in D4 --> expected result: reject.
  3) coins created and spent in E2, being double spent in F2. --> expected result: reject.
  4) coins created in D and spent in E3. --> expected result: reject.
  5) coins create in D, spent in F and then double spent in F3. --> expected result: reject.
  6) coins created in G and G3, being spent in H and H3 --> expected result: pass.

ACKs for top commit:
  random-zebra:
    re-utACK 8c7dd6c0bb732404018889b622693becfb29b5d2

Tree-SHA512: 33323abc8d458d335d27bd3febef321debb7008f0f0d132d29de0de06fab2591cf5fe5ca8be03812f79b651bbe0aeb98b44d532d9135b6725e6073ebb7c418bd

c5ef662... by furszy <email address hidden>

Merge #2584: [Refactor] Reorder mnw processing and validation

e8559fc2638045909c9e34c0cb843e8d3069e2b5 [Refactor] make AddWinningMasternode a void function (random-zebra)
5aaa02a5c663753b957a5942e57d3ba72e2af266 [Test] add mnwinner case for non-existent MN. (furszy)
e68773b60ae1c37227fad5cce2e918137c55da87 [Refactor] Fix checks order for mnw processing (random-zebra)

Pull request description:

  Extracted from #2421 (and based on top of it) so #2550 can be merged in between.

ACKs for top commit:
  furszy:
    utACK e8559fc2638045909c9e34c0cb843e8d3069e2b5 after rebase

Tree-SHA512: 659d4ca43502f8e1e8f6ddbf7c815f6a07a69625f00c8ab71b7d8e9c97b85e90d97b18ccc988dcfd4d345d5f79932128abdaa0f0634380be7d715d3a3e45c6fc

02a0060... by furszy <email address hidden>

Merge #2627: [GUI] Correct proposal large title for being cut when the app window width isn't big enough

4de23385b56e7adaefd24dea5f56bf5067d72623 GUI: correct proposal large title for being cut if the app window is too small. (furszy)

Pull request description:

  Found it while was testing #2626, a small bug that occurs when the app window width isn't big enough to automatically expand the three column grid proposal cards. So the last letter of proposals with large names are being cut.

  For example, look at the proposal in the middle:

  Before the fix:
  <img width="1034" alt="Screen Shot 2021-11-04 at 6 44 15 PM" src="https://user-images.githubusercontent.com/5377650/140424886-366c12bc-4ce3-43c4-bcd6-89d35ec0f634.png">

  After the fix:
  <img width="944" alt="Screen Shot 2021-11-04 at 6 40 09 PM" src="https://user-images.githubusercontent.com/5377650/140424926-3e7965ae-1db6-4c3e-9f5c-d2adb3098b4b.png">

ACKs for top commit:
  random-zebra:
    ACK 4de23385b56e7adaefd24dea5f56bf5067d72623
  Fuzzbawls:
    ACK 4de23385b56e7adaefd24dea5f56bf5067d72623

Tree-SHA512: 077bd8ea8658decfa9209933ee190605597bd1397aaa66573c7745a3b38ceb3a83c360be693c8d0c3960133d78ce5f5de47d2a57858ef654bde0001b333ea73e