This adds shield address support to the `setlabel` and
`getaddressesbylabel` RPC commands. `setlabel` now accepts and validates
shield address input argument, where `getaddressesbylabel` now returns
shield addresses with a label matching the input argument.
Merge #2608: [RPC] Fully deprecate the autocombinerewards method
28a160e31ba46691ce35c5b3a9c69a1c79a4b46a [RPC] Fully deprecate the autocombinerewards method (Fuzzbawls)
Pull request description:
This command was first marked soft-deprecated, and replaced with
explicit setter/getter commands, in v5.3.0.
This fully deprecates it by returning an error when calling, unless the
node is started with `-deprecatedrpc=autocombinerewards`. Revived the
`rpc_deprecated.py` functional test to cover this.
ACKs for top commit:
random-zebra:
utACK 28a160e31ba46691ce35c5b3a9c69a1c79a4b46a
furszy:
utACK 28a160e31ba46691ce35c5b3a9c69a1c79a4b46a and merging..
Merge #2591: [Mempool] Clean zc transactions from check() method
88593884545fc60e3b064d95d7631bd5834bd303 [Mempool] zc transactions are no longer accepted in the mempool in the first place, no need to check them. (furszy)
Pull request description:
Zerocoin transactions are no longer accepted in the mempool in the first place, no need to try to check something that will not be there.
ACKs for top commit:
random-zebra:
utACK 88593884545fc60e3b064d95d7631bd5834bd303
77df5361243672e2d97edf776b7ae528e748d0a4 [rpc] Remove auth cookie on shutdown (practicalswift)
Pull request description:
Something that faced investigating other stuff. Straightforward #10139.
ACKs for top commit:
Fuzzbawls:
utACK 77df5361243672e2d97edf776b7ae528e748d0a4
random-zebra:
utACK 77df5361243672e2d97edf776b7ae528e748d0a4 and merging...
[RPC] Fully deprecate the autocombinerewards method
This command was first marked soft-deprecated, and replaced with
explicit setter/getter commands, in v5.3.0.
This fully deprecates it by returning an error when calling, unless the
node is started with `-deprecatedrpc=autocombinerewards`. Revived the
`rpc_deprecated.py` functional test to cover this.
Merge #2580: [TierTwo] Budget vote functions decoupled from RPC
7dab6f0bc9da1e28d1373a50e1582030a1a9c912 Remove not needed wallet.h dependency from activemasternode.h (furszy)
a6a82cd1fcec5bad9dc87b1e9f4426addd3ff8b7 Cleanup: Unneeded CActiveMasternode constructor. (furszy)
b06e52443399f930630e52c561728477808b1fcb Refactor: budgetman, clean duplicate GetAllProposalsOrdered(). (furszy)
82dcb5149d086ef604d96450040661b7106fa7ac Cleanup: budget replace GetVotesHashes() for simple GetVotes() (furszy)
dfe058fd1f151d00bad92284f4e76f114f8faa9f Budget: PROPOSAL_MIN_AMOUNT constant created instead of hardcoded value (furszy)
cdee9dd0a7375e18444cd97bf7a755eef321e7d6 Budget refactor: IsExpired() to updateExpired() and create a separate const function IsExpired() that do not modify the object. (furszy)
d43bb05792b77e5d58b884a2610ada1341fe8f34 [Move-only] budget vote functions moved to budgetutil so it can be called from the RPC server and the GUI. (furszy)
d99db3288c34276f428f7575bbe1884e0b0eea6a [RPC] budget: do not use RPC error/link in the mn vote util functions (furszy)
Pull request description:
This work is decoupled from #2406, focused on the backend budget related refactorings/changes.
None of the modifications here has any consensus nor functionality change, the work mainly generalize and decouple code to allow the new governance GUI workflows to be able to use the same functions that are used in the RPC server commands workflows.
Final decouple from #2406 before is ready to get merged :).
ACKs for top commit:
random-zebra:
Code ACK 7dab6f0bc9da1e28d1373a50e1582030a1a9c912
018c41b065937da5cdc272ecfb5481c025d62da0 Depends: Add M1 macOS support to Rust dependency (Fuzzbawls)
01881eb426e847f699d56cc5693bf6e92fb063ca [Depends] Bump Rust to v1.54.0 (Fuzzbawls)
Pull request description:
Bumps our Rust toolchain dependency to a more recent version (1.54.0), which contains Tier 2 support for aarch64-apple targets as well as fixes a bug with windows library file extensions when compiling with mingw.
We still need to use our own custom compiled toolchain to avoid breaking the minimum ABI compatibility for linux builds.
ACKs for top commit:
furszy:
gitian went well, ACK 018c41b065937da5cdc272ecfb5481c025d62da0
random-zebra:
ACK 018c41b065937da5cdc272ecfb5481c025d62da0
Merge #2568: [BUG][GUI] Refine bytes/fee/"after fee" calculation in coin-control
d2842200013020c9aeb4e0023568b6a5dbc078b3 [BUG][GUI] Refine bytes/fee/"after fee" calculation in coin-control (random-zebra)
Pull request description:
Should close #2156
This bug is caused by the fact that a transparent input is *usally* 148 bytes (149 for p2cs spends), but can also be 149 sometimes (150 for p2cs spends), depending on the script length.
When a user copies "After fee" in coin-control, and sends it to a single recipient, this extra fee is typically (with few coins selected) offset by the lack of change output. But, when many inputs are selected in coin control, this becomes relevant.
Also:
- remove the duplicated definitions of `CTXIN_SPEND_DUST_SIZE` and `CTXOUT_REGULAR_SIZE` in `sapling_operation.h`
- remove the extra byte for the (nullopt) special payload, as that is not serialized for version=1 or type=0 transactions (and currently isn't possible to send special txes with the GUI).
ACKs for top commit:
furszy:
looks good, ACK d2842200013020c9aeb4e0023568b6a5dbc078b3.
