AppMenu GTK+

Merge lp:~furyhunter/appmenu-gtk/eclipse-remove into lp:appmenu-gtk/0.4

  1. eclipse-remove
  2. Merge into trunk
Proposed by Ronald Kinard
Status: Work in progress
Proposed branch: lp:~furyhunter/appmenu-gtk/eclipse-remove
Merge into: lp:appmenu-gtk/0.4
Diff against target: 11 lines (+0/-1)
1 file modified
src/bridge.c (+0/-1)
To merge this branch: bzr merge lp:~furyhunter/appmenu-gtk/eclipse-remove
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Disapprove
Andrea Cimitan (community) Approve
Charles Kerr Pending
Review via email: mp+74902@code.launchpad.net

Description of the change

Since the Eclipse menu bug was fixed in a previous merge <https://code.launchpad.net/~mterry/dbusmenu/eclipse-rcp/+merge/59277>, Eclipse should be removed from the blacklist. This branch reverts that previous change.

To post a comment you must log in.
Revision history for this message
Andrea Cimitan (cimi) :
review: Approve
Reply
Revision history for this message
Lars Karlitski (larsu) wrote :

Reject, because eclispe hangs in its splash screen when it is removed from the blacklist.

review: Disapprove
Reply

Unmerged revisions

138. By Ronald Kinard

Remove Eclipse from the blacklist.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/bridge.c'
2--- src/bridge.c 2011-07-25 17:30:57 +0000
3+++ src/bridge.c 2011-09-11 09:18:22 +0000
4@@ -907,7 +907,6 @@
5 || (g_strcmp0 (prg, "midori") == 0)
6 || (g_strcmp0 (prg, "firefox-bin") == 0)
7 || (g_strcmp0 (prg, "thunderbird-bin") == 0)
8- || (g_strcmp0 (prg, "Eclipse") == 0)
9 || (g_strcmp0 (prg, "emacs") == 0)
10 || (g_strcmp0 (prg, "emacs23") == 0)
11 || (g_strcmp0 (prg, "emacs23-lucid") == 0)

Subscribers

People subscribed via source and target branches