Merge lp:~fullname1/ginn/luke-hd2-approved into lp:ginn

Proposed by Mohamed IKBEL Boulabiar
Status: Merged
Merge reported by: Mohamed IKBEL Boulabiar
Merged at revision: not available
Proposed branch: lp:~fullname1/ginn/luke-hd2-approved
Merge into: lp:ginn
Diff against target: 120 lines (+90/-2)
1 file modified
etc/wishes.xml (+90/-2)
To merge this branch: bzr merge lp:~fullname1/ginn/luke-hd2-approved
Reviewer Review Type Date Requested Status
Mohamed IKBEL Boulabiar (community) Approve
Review via email: mp+42177@code.launchpad.net

Description of the change

add more configurations to wishes.xml file.

evince: Use Page Up, Page Down instead of Up Down; add Left, Right.
eog: Initial support: Rotate; zoom in, out; scroll up, down
fennec: Initial support: Zoom in, out
firefox: Initial support: Scroll up, down, left, right

All changes are successfully tested on the HTC HD2 touchscreen.

To post a comment you must log in.
Revision history for this message
Mohamed IKBEL Boulabiar (boulabiar) wrote :

Some wishes contain small typing errors.

As your first patch, I'll accept them then I'll correct missing points.
The attributes, keys and buttons are described in files inside the ginn/etc/ directory.

Thanks for adding this !

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'etc/wishes.xml'
2--- etc/wishes.xml 2010-11-25 17:10:28 +0000
3+++ etc/wishes.xml 2010-11-29 21:34:53 +0000
4@@ -99,13 +99,13 @@
5 <wish gesture="Drag" fingers="2">
6 <action name="action5" when="update">
7 <trigger prop="delta y" min="20" max="80"/>
8- <key>Up</key>
9+ <key>Page Up</key>
10 </action>
11 </wish>
12 <wish gesture="Drag" fingers="2">
13 <action name="action6" when="update">
14 <trigger prop="delta y" min="-80" max="-20"/>
15- <key>Down</key>
16+ <key>Page Down</key>
17 </action>
18 </wish>
19 <wish gesture="Pinch" fingers="2">
20@@ -120,6 +120,18 @@
21 <key>KP_Add</key>
22 </action>
23 </wish>
24+ <wish gesture="Drag" fingers="2">
25+ <action name="action5" when="update">
26+ <trigger prop="delta x" min="20" max="80"/>
27+ <key>Left</key>
28+ </action>
29+ </wish>
30+ <wish gesture="Drag" fingers="2">
31+ <action name="action6" when="update">
32+ <trigger prop="delta x" min="-80" max="-20"/>
33+ <key>Right</key>
34+ </action>
35+ </wish>
36 </application>
37 <application name="okular">
38 <wish gesture="Pinch" fingers="2">
39@@ -149,6 +161,82 @@
40 </action>
41 </wish>
42 </application>
43+ <application name="eog">
44+ <wish gesture="Pinch" fingers="2">
45+ <action name="action1" when="update">
46+ <trigger prop="radius delta" min="-200" max="-40"/>
47+ <key>KP_Subtract</key>
48+ </action>
49+ </wish>
50+ <wish gesture="Pinch" fingers="2">
51+ <action name="action1" when="update">
52+ <trigger prop="radius delta" min="40" max="200"/>
53+ <key>KP_Add</key>
54+ </action>
55+ </wish>
56+ <wish gesture="Drag" fingers="2">
57+ <action name="action5" when="update">
58+ <trigger prop="delta y" min="20" max="80"/>
59+ <key>Page Up</key>
60+ </action>
61+ </wish>
62+ <wish gesture="Drag" fingers="2">
63+ <action name="action6" when="update">
64+ <trigger prop="delta y" min="-80" max="-20"/>
65+ <key>Page Down</key>
66+ </action>
67+ </wish>
68+ <wish gesture="Rotate" fingers="2">
69+ <action name="rotatecw" when="update">
70+ <key modifier1="Control_L">R</key>
71+ </action>
72+ </wish>
73+ <wish gesture="Rotate" fingers="2">
74+ <action name="rotateccw" when="update">
75+ <key modifier1="Control_L" modifier2="Shift_L">R</key>
76+ </action>
77+ </wish>
78+ </application>
79+ <application name="fennec">
80+ <wish gesture="Pinch" fingers="2">
81+ <action name="action1" when="update">
82+ <trigger prop="radius delta" min="-200" max="-40"/>
83+ <key modifier1="Control_L">Down</key>
84+ </action>
85+ </wish>
86+ <wish gesture="Pinch" fingers="2">
87+ <action name="action1" when="update">
88+ <trigger prop="radius delta" min="40" max="200"/>
89+ <key modifier1="Control_L">Up</key>
90+ </action>
91+ </wish>
92+ </application>
93+ <application name="firefox">
94+ <wish gesture="Drag" fingers="2">
95+ <action name="action5" when="update">
96+ <trigger prop="delta y" min="20" max="80"/>
97+ <key>Page Up</key>
98+ </action>
99+ </wish>
100+ <wish gesture="Drag" fingers="2">
101+ <action name="action6" when="update">
102+ <trigger prop="delta y" min="-80" max="-20"/>
103+ <key>Page Down</key>
104+ </action>
105+ </wish>
106+ <wish gesture="Drag" fingers="2">
107+ <action name="action5" when="update">
108+ <trigger prop="delta x" min="20" max="80"/>
109+ <key>Left</key>
110+ </action>
111+ </wish>
112+ <wish gesture="Drag" fingers="2">
113+ <action name="action6" when="update">
114+ <trigger prop="delta x" min="-80" max="-20"/>
115+ <key>Right</key>
116+ </action>
117+ </wish>
118+ </application>
119 </applications>
120 </ginn>
121