LAVA Dispatcher

Merge lp:~fu-wei/lava-dispatcher/multinode into lp:lava-dispatcher/multinode

  1. multinode
  2. Merge into multinode
Proposed by Fu Wei
Status: Merged
Approved by: Neil Williams
Approved revision: no longer in the source branch.
Merged at revision: 687
Proposed branch: lp:~fu-wei/lava-dispatcher/multinode
Merge into: lp:lava-dispatcher/multinode
Diff against target: 11 lines (+1/-1)
1 file modified
lava_test_shell/multi_node/lava-multi-node.lib (+1/-1)
To merge this branch: bzr merge lp:~fu-wei/lava-dispatcher/multinode
Reviewer Review Type Date Requested Status
Neil Williams Pending
Review via email: mp+181806@code.launchpad.net

Description of the change

Fix the bug of disabling debug info in multi-node API shell scritps

To post a comment you must log in.
lp:~fu-wei/lava-dispatcher/multinode updated
687. By Neil Williams

Fu Wei 2013-08-23 Fix the bug of disabling debug info in multi-node API
 shell scripts.

Revision history for this message
Antonio Terceiro (terceiro) wrote :

> === modified file 'lava_test_shell/multi_node/lava-multi-node.lib'
> --- lava_test_shell/multi_node/lava-multi-node.lib 2013-08-01 12:42:35 +0000
> +++ lava_test_shell/multi_node/lava-multi-node.lib 2013-08-23 12:10:34 +0000
> @@ -23,7 +23,7 @@
>
> _lava_multi_node_debug () {
>
> -if [ -n $LAVA_MULTI_NODE_DEBUG ] ; then
> +if [ -n "$LAVA_MULTI_NODE_DEBUG" ] ; then
> echo "${MESSAGE_COMMAND}_DEBUG $@ $(date)>"
> fi

most of the time you use variables in a shell script, they should be
surrounded by double quotes, so it would be nice to do this all over
those shell scripts.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava_test_shell/multi_node/lava-multi-node.lib'
2--- lava_test_shell/multi_node/lava-multi-node.lib 2013-08-01 12:42:35 +0000
3+++ lava_test_shell/multi_node/lava-multi-node.lib 2013-08-23 12:12:26 +0000
4@@ -23,7 +23,7 @@
5
6 _lava_multi_node_debug () {
7
8-if [ -n $LAVA_MULTI_NODE_DEBUG ] ; then
9+if [ -n "$LAVA_MULTI_NODE_DEBUG" ] ; then
10 echo "${MESSAGE_COMMAND}_DEBUG $@ $(date)>"
11 fi
12

Subscribers

People subscribed via source and target branches

to status/vote changes: