Merge ~freyes/stsstack-bundles:set-cephfs-as-default into stsstack-bundles:master

Proposed by Felipe Reyes
Status: Merged
Merged at revision: e439ca1ab1d441a5f48153fbeceaebfa106d884f
Proposed branch: ~freyes/stsstack-bundles:set-cephfs-as-default
Merge into: stsstack-bundles:master
Diff against target: 32 lines (+5/-1)
3 files modified
kubernetes/configure (+0/-1)
kubernetes/pipeline/02configure (+1/-0)
overlays/ceph-fs-k8s.yaml (+4/-0)
Reviewer Review Type Date Requested Status
Hemanth Nakkina Approve
Jorge Niedbalski (community) Needs Fixing
Review via email: mp+394374@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Felipe Reyes (freyes) wrote :

feel free to suggest a better name :D I just used what came to my mind

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

does this needs to be run on ./configure?

review: Needs Information
Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

just to complement what we talked in ~hackers, configure should check if ceph-fs is present, and if present, the proposed script should be run regardless.

review: Needs Fixing
Revision history for this message
Hemanth Nakkina (hemanth-n) wrote :

ceph-xfs annotation storageclass.kubernetes.io/is-default-class is updated back to true by the kubernetes-master charm during update-status.

Change the script to use charm configuration
juju config kubernetes-master default-storage=cephfs

review: Needs Fixing
Revision history for this message
Felipe Reyes (freyes) wrote :

On Fri, 2020-11-27 at 04:41 +0000, Hemanth Nakkina wrote:
> Review: Needs Fixing
>
> ceph-xfs annotation storageclass.kubernetes.io/is-default-class is
> updated back to true by the kubernetes-master charm during update-
> status.
>
> Change the script to use charm configuration
> juju config kubernetes-master default-storage=cephfs

:-O this was way simpler, thanks, will do.

--
Felipe Reyes
Software Sustaining Engineer @ Canonical
# Email: <email address hidden> (GPG:0x9B1FFF39)
# Launchpad: ~freyes | IRC: freyes

Revision history for this message
Felipe Reyes (freyes) wrote :

On Fri, 2020-11-27 at 14:24 +0000, Felipe Reyes wrote:
> On Fri, 2020-11-27 at 04:41 +0000, Hemanth Nakkina wrote:
> > Review: Needs Fixing
> >
> > ceph-xfs annotation storageclass.kubernetes.io/is-default-class is
> > updated back to true by the kubernetes-master charm during update-
> > status.
> >
> > Change the script to use charm configuration
> > juju config kubernetes-master default-storage=cephfs
>
> :-O this was way simpler, thanks, will do.

done. Ready for review.

>
--
Felipe Reyes
Software Sustaining Engineer @ Canonical
# Email: <email address hidden> (GPG:0x9B1FFF39)
# Launchpad: ~freyes | IRC: freyes

Revision history for this message
Hemanth Nakkina (hemanth-n) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/kubernetes/configure b/kubernetes/configure
2index 5a1a111..3cd05b1 100755
3--- a/kubernetes/configure
4+++ b/kubernetes/configure
5@@ -32,5 +32,4 @@ if [[ `juju status keystone --format=json 2>/dev/null| jq '.machines| length'` -
6 source kube-keystone.sh
7 fi
8
9-
10 kubectl --namespace kube-system get pods
11diff --git a/kubernetes/pipeline/02configure b/kubernetes/pipeline/02configure
12index 91bdea0..a3a862a 100644
13--- a/kubernetes/pipeline/02configure
14+++ b/kubernetes/pipeline/02configure
15@@ -74,6 +74,7 @@ do
16 ;;
17 --ceph-fs)
18 MOD_OVERLAYS+=( "ceph-fs.yaml" )
19+ MOD_OVERLAYS+=( "ceph-fs-k8s.yaml" )
20 ;;
21 --ceph-fs-ha*)
22 get_units $1 __NUM_CEPH_FS_UNITS__ 3
23diff --git a/overlays/ceph-fs-k8s.yaml b/overlays/ceph-fs-k8s.yaml
24new file mode 100644
25index 0000000..9e255b4
26--- /dev/null
27+++ b/overlays/ceph-fs-k8s.yaml
28@@ -0,0 +1,4 @@
29+applications:
30+ kubernetes-master:
31+ options:
32+ default-storage: cephfs

Subscribers

People subscribed via source and target branches