Merge ~freyes/snap-prometheus-ovn-exporter:bug/1994167 into snap-prometheus-ovn-exporter:master

Proposed by Felipe Reyes
Status: Merged
Approved by: Eric Chen
Approved revision: 0045c6cf0c0b90495f36c7f2bdf035c04cfb8de2
Merged at revision: 7272283fdc01fb140563e7cbf78b11d3f924f2e9
Proposed branch: ~freyes/snap-prometheus-ovn-exporter:bug/1994167
Merge into: snap-prometheus-ovn-exporter:master
Diff against target: 19 lines (+7/-0)
1 file modified
snapcraft.yaml (+7/-0)
Reviewer Review Type Date Requested Status
Eric Chen Approve
BootStack Reviewers Pending
Review via email: mp+432143@code.launchpad.net

Commit message

Add ppc64el and s390x architectures

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Eric Chen (eric-chen) wrote :

LGTM.
But please attach the log of unit/func test if available.

review: Needs Information
Revision history for this message
Eric Chen (eric-chen) wrote :

As we discussed in MM, there is no unit/func in this snap.
Please test it manually and report the result. That may be the only thing we can do now.

Revision history for this message
Felipe Reyes (freyes) wrote :
Download full text (5.5 KiB)

Pushed a new revision that explicitly sets run-on/build-on stanzas, the remote-build worked ok on the 4 architectures.

I'm testing the snap for s390x now,

$ snapcraft remote-build
snapcraft remote-build is experimental and is subject to change - use with caution.
Using build ID snapcraft-prometheus-ovn-exporter-2fe4c143906034338390d57855414561
All data sent to remote builders will be publicly available. Are you sure you want to continue? [Y/n]: y
Packaging sources for scripts...
Sending build data to Launchpad... (https://freyes:<token>@git.launchpad.net/~freyes/+git/snapcraft-prometheus-ovn-exporter-2fe4c143906034338390d57855414561/)
Enumerating objects: 7, done.
Counting objects: 100% (7/7), done.
Delta compression using up to 8 threads
Compressing objects: 100% (4/4), done.
Writing objects: 100% (7/7), 2.17 KiB | 2.17 MiB/s, done.
Total 7 (delta 0), reused 0 (delta 0), pack-reused 0
To https://git.launchpad.net/~freyes/+git/snapcraft-prometheus-ovn-exporter-2fe4c143906034338390d57855414561/
 * [new branch] HEAD -> master
If interrupted, resume with: 'snapcraft remote-build --recover --build-id snapcraft-prometheus-ovn-exporter-2fe4c143906034338390d57855414561'
Building snap package for amd64, arm64, ppc64el, and s390x. This may take some time to finish.
Build status as of 2022-10-26 11:29:43.831842:
 arch=s390x state=Needs building
 arch=ppc64el state=Needs building
 arch=arm64 state=Needs building
 arch=amd64 state=Needs building
Build status as of 2022-10-26 11:30:15.248207:
 arch=ppc64el state=Currently building
 arch=arm64 state=Currently building
 arch=s390x state=Currently building
 arch=amd64 state=Currently building
Build status as of 2022-10-26 11:30:46.749661:
 arch=ppc64el state=Currently building
 arch=arm64 state=Currently building
 arch=s390x state=Currently building
 arch=amd64 state=Currently building
Build status as of 2022-10-26 11:31:17.469247:
 arch=ppc64el state=Currently building
 arch=arm64 state=Currently building
 arch=s390x state=Currently building
 arch=amd64 state=Currently building
Build status as of 2022-10-26 11:31:48.054731:
 arch=ppc64el state=Currently building
 arch=arm64 state=Currently building
 arch=s390x state=Currently building
 arch=amd64 state=Currently building
Build status as of 2022-10-26 11:32:19.783174:
 arch=ppc64el state=Currently building
 arch=arm64 state=Currently building
 arch=s390x state=Currently building
 arch=amd64 state=Currently building
Build status as of 2022-10-26 11:32:51.084563:
 arch=amd64 state=Uploading build
 arch=ppc64el state=Currently building
 arch=arm64 state=Currently building
 arch=s390x state=Currently building
Build status as of 2022-10-26 11:33:22.975122:
 arch=amd64 state=Successfully built
 arch=ppc64el state=Currently building
 arch=arm64 state=Currently building
 arch=s390x state=Currently building
Build status as of 2022-10-26 11:33:53.657246:
 arch=amd64 state=Successfully built
 arch=ppc64el state=Currently building
 arch=arm64 state=Currently building
 arch=s390x state=Currently building
Build status as of 2022-10-26 11:34:24.348850:
 arch=amd64 state=Successfully built
 arch=ppc64el state=Currently building
 arch=arm64 state=Currently building...

Read more...

Revision history for this message
Felipe Reyes (freyes) wrote :

ubuntu@juju-f2e777-0-lxd-0:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 22.04.1 LTS
Release: 22.04
Codename: jammy
ubuntu@juju-f2e777-0-lxd-0:~$ uname -a
Linux juju-f2e777-0-lxd-0 5.15.0-52-generic #58-Ubuntu SMP Thu Oct 13 08:04:48 UTC 2022 s390x s390x s390x GNU/Linux
ubuntu@juju-f2e777-0-lxd-0:~$ sudo snap install --dangerous ./prometheus-ovn-exporter_1.0.3_s390x.snap
prometheus-ovn-exporter 1.0.3 installed
ubuntu@juju-f2e777-0-lxd-0:~$ sudo systemctl status snap.prometheus-ovn-exporter.ovn-exporter.service
● snap.prometheus-ovn-exporter.ovn-exporter.service - Service for snap application prometheus-ovn-exporter.ovn-exporter
     Loaded: loaded (/etc/systemd/system/snap.prometheus-ovn-exporter.ovn-exporter.service; enabled; vendor preset: enabled)
     Active: active (running) since Wed 2022-10-26 14:57:49 UTC; 17s ago
   Main PID: 84041 (ovn-exporter)
      Tasks: 5 (limit: 57600)
     Memory: 7.3M
        CPU: 116ms
     CGroup: /system.slice/snap.prometheus-ovn-exporter.ovn-exporter.service
             └─84041 /snap/prometheus-ovn-exporter/x1/bin/ovn-exporter -web.listen-address=:9476 -database.northbound.file.data.path /var/lib/ovn/ovnnb_db.db -database.northbound.file.log.path /var/log/ovn>

Oct 26 14:57:49 juju-f2e777-0-lxd-0 systemd[1]: Started Service for snap application prometheus-ovn-exporter.ovn-exporter.
Oct 26 14:57:49 juju-f2e777-0-lxd-0 prometheus-ovn-exporter.ovn-exporter[84041]: time="2022-10-26T14:57:49Z" level=info msg="Starting ovn-exporter (version=1.0.3, branch=HEAD, revision=v1.0.3)" source="mai>
Oct 26 14:57:49 juju-f2e777-0-lxd-0 prometheus-ovn-exporter.ovn-exporter[84041]: time="2022-10-26T14:57:49Z" level=info msg="Build context (go=go1.14.15, user=snapcraft, date=2022-10-26)" source="main.go:1>
Oct 26 14:57:49 juju-f2e777-0-lxd-0 prometheus-ovn-exporter.ovn-exporter[84041]: time="2022-10-26T14:57:49Z" level=error msg="ovn-exporter failed to finalize exporter calls properly: [failed connecting to >
Oct 26 14:57:49 juju-f2e777-0-lxd-0 prometheus-ovn-exporter.ovn-exporter[84041]: time="2022-10-26T14:57:49Z" level=info msg="OVS system-id: unknown" source="main.go:170"
Oct 26 14:57:49 juju-f2e777-0-lxd-0 prometheus-ovn-exporter.ovn-exporter[84041]: time="2022-10-26T14:57:49Z" level=info msg="Listening on :9476" source="main.go:185"

Revision history for this message
Felipe Reyes (freyes) wrote :

the daemon prometheus-ovn-exporter is running fine.

Revision history for this message
Eric Chen (eric-chen) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 7272283fdc01fb140563e7cbf78b11d3f924f2e9

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 736b995..8b84484 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -7,7 +7,14 @@ description: |
6 Exporter that exposes information gathered from OVN for use by the Prometheus monitoring system
7 confinement: strict
8 architectures:
9+ - build-on: amd64
10+ run-on: amd64
11 - build-on: arm64
12+ run-on: arm64
13+ - build-on: ppc64el
14+ run-on: ppc64el
15+ - build-on: s390x
16+ run-on: s390x
17 parts:
18 ovn-exporter:
19 plugin: go

Subscribers

People subscribed via source and target branches

to all changes: