Code review comment for ~freyes/maas:lp1880495

Revision history for this message
Alberto Donato (ack) wrote :

Hi, change looks good.

To remove dependencies on model code, these imports should also br dropped:

import maasserver.models.dnsresource
from maasserver.models.domain import DEFAULT_DOMAIN_NAME
import maasserver.models.node

DEFAULT_DOMAIN_NAME can be just defined locally with the same value, the others are actually unused.

Note that the patch is at a different location in master (src/maasserver/migrations/maasserver/0011_domain_data.py), but other than that the change should apply cleanly.

Thanks!

« Back to merge proposal