Merge lp:~freyes/lazr.restfulclient/lp1500460 into lp:lazr.restfulclient

Proposed by Felipe Reyes on 2016-05-12
Status: Rejected
Rejected by: Colin Watson on 2017-09-05
Proposed branch: lp:~freyes/lazr.restfulclient/lp1500460
Merge into: lp:lazr.restfulclient
Diff against target: 11 lines (+1/-0)
1 file modified
setup.py (+1/-0)
To merge this branch: bzr merge lp:~freyes/lazr.restfulclient/lp1500460
Reviewer Review Type Date Requested Status
Colin Watson 2016-05-12 Needs Fixing on 2016-05-13
Review via email: mp+294573@code.launchpad.net

Description of the change

Dear Maintainers,

This patch adds simplejson as a dependency, because as be seen in the bug 1500460 in clean environments lazr.restfulclient fails with the following error:

Traceback (most recent call last):
  File ".tox/pep8/bin/charm-proof", line 7, in <module>
    from charmtools.proof import main
  File ".tox/pep8/local/lib/python2.7/site-packages/charmtools/proof.py", line 23, in <module>
    from charms import Charm
  File ".tox/pep8/local/lib/python2.7/site-packages/charmtools/charms.py", line 13, in <module>
    from launchpadlib.launchpad import Launchpad
  File ".tox/pep8/local/lib/python2.7/site-packages/launchpadlib/launchpad.py", line 33, in <module>
    from lazr.restfulclient.resource import (
  File ".tox/pep8/local/lib/python2.7/site-packages/lazr/restfulclient/resource.py", line 36, in <module>
    import simplejson
ImportError: No module named simplejson

Best,

To post a comment you must log in.
Colin Watson (cjwatson) wrote :

Thanks for the patch. However, I don't think we should do this; the current code doesn't in fact need simplejson on any remotely recent version of Python. I'll see if I can sort out an updated release on PyPI.

If you wanted to produce a modified version of this branch, I think it would be entirely reasonable nowadays to remove the simplejson fallback code paths; that would reduce confusion.

review: Needs Fixing
Felipe Reyes (freyes) wrote :

Right, the problem is only with the version available in pypi (0.13.1) which doesn't contain the patch from revno 124.1.2[0], if you could push into pypi the version available in Xenial would be great.

[0] revno: 124.1.2
committer: Barry Warsaw <email address hidden>
branch nick: rcpy3
timestamp: Mon 2012-06-04 15:54:58 -0400
message:
  The start of a port of lazr.restfulclient to Python 3. Still untested because
  of the unadvertized requirement for a Python 3 lazr.restful.

Colin Watson (cjwatson) wrote :

I've uploaded lazr.restfulclient 0.13.5 to PyPI, including the necessary patch for this. Sorry for the long delay.

As a result, I'm rejecting this branch since I don't think it's needed, as previously explained.

Unmerged revisions

147. By Felipe Reyes on 2016-05-12

Add simplejson as dependency

Fixes LP: #1500460

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2015-04-08 20:07:48 +0000
3+++ setup.py 2016-05-12 22:19:03 +0000
4@@ -57,6 +57,7 @@
5 'oauth',
6 'setuptools',
7 'wadllib>=1.1.4',
8+ 'simplejson',
9 ],
10 url='https://launchpad.net/lazr.restfulclient',
11 download_url= 'https://launchpad.net/lazr.restfulclient/+download',

Subscribers

People subscribed via source and target branches