Merge lp:~freyes/charms/trusty/hacluster/debug-config into lp:~openstack-charmers/charms/trusty/hacluster/next

[Felipe Reyes]

Expose a configuration option (debug) to enable corosync debugging.

This is really helpful to get a complete history of corosync decisions to elect the master, fencing, etc.

[Jorge Niedbalski (niedbalski)]

LGTM +1

review: Approve

[Edward Hope-Morley (hopem)]

lgtm +1

review: Approve

[Billy Olsen (billy-olsen)]

lgtm +1, thanks Felipe!

review: Approve

=== modified file 'config.yaml'
--- config.yaml	2014-11-19 15:51:11 +0000
+++ config.yaml	2014-12-15 13:30:17 +0000
@@ -90,3 +90,7 @@
     default: "multicast"
     description: |
       Two supported modes are multicast (udp) or unicast (udpu)
+  debug:
+    default: False
+    type: boolean
+    description: Enable debug logging

=== modified file 'hooks/hooks.py'
--- hooks/hooks.py	2014-12-08 18:31:37 +0000
+++ hooks/hooks.py	2014-12-15 13:30:17 +0000
@@ -127,6 +127,7 @@
         'ip_version': ip_version,
         'ha_nodes': get_ha_nodes(),
         'transport': get_transport(),
+        'debug': config('debug'),
     }
     if None not in conf.itervalues():
         return conf
@@ -144,6 +145,7 @@
                 'ip_version': ip_version,
                 'ha_nodes': get_ha_nodes(),
                 'transport': get_transport(),
+                'debug': config('debug'),
             }
 
             if config('prefer-ipv6'):

=== modified file 'templates/corosync.conf'
--- templates/corosync.conf	2014-12-08 18:41:32 +0000
+++ templates/corosync.conf	2014-12-15 13:30:17 +0000
@@ -84,9 +84,9 @@
 	to_logfile: no
 	to_syslog: yes
 	syslog_facility: daemon
-    debug: off
+        debug: {% if debug %}on{% else %}off{% endif %}
 	logger_subsys {
 		subsys: QUORUM
-		debug: off
+		debug: {% if debug %}on{% else %}off{% endif %}
 	}
 }

=== modified file 'unit_tests/test_hacluster_hooks.py'
--- unit_tests/test_hacluster_hooks.py	2014-12-08 20:15:23 +0000
+++ unit_tests/test_hacluster_hooks.py	2014-12-15 13:30:17 +0000
@@ -1,10 +1,26 @@
+from __future__ import print_function
+
 import mock
+import os
+import re
+import shutil
+import tempfile
 import unittest
 
 with mock.patch('charmhelpers.core.hookenv.config'):
     import hooks as hacluster_hooks
 
 
+def local_log(msg, level='INFO'):
+    print('[{}] {}'.format(level, msg))
+
+
+def write_file(path, content, *args, **kwargs):
+    with open(path, 'w') as f:
+        f.write(content)
+        f.flush()
+
+
 class SwiftContextTestCase(unittest.TestCase):
 
     @mock.patch('hooks.config')
@@ -17,3 +33,59 @@
 
         mock_config.return_value = 'hafu'
         self.assertRaises(ValueError, hacluster_hooks.get_transport)
+
+
[e-mail]('hooks.log', local_log)
[e-mail]('hooks.write_file', write_file)
+class TestCorosyncConf(unittest.TestCase):
+
+    def setUp(self):
+        self.tmpdir = tempfile.mkdtemp()
+        hacluster_hooks.COROSYNC_CONF = os.path.join(self.tmpdir,
+                                                     'corosync.conf')
+
+    def tearDown(self):
+        shutil.rmtree(self.tmpdir)
+
+    def test_debug_on(self):
+        self.check_debug(True)
+
+    def test_debug_off(self):
+        self.check_debug(False)
+
+    @mock.patch('hooks.relation_get')
+    @mock.patch('hooks.related_units')
+    @mock.patch('hooks.relation_ids')
+    @mock.patch('hacluster.get_network_address')
+    @mock.patch('hooks.config')
+    def check_debug(self, enabled, mock_config, get_network_address,
+                    relation_ids, related_units, relation_get):
+        cfg = {'debug': enabled,
+               'prefer-ipv6': False,
+               'corosync_transport': 'udpu',
+               'corosync_mcastaddr': 'corosync_mcastaddr'}
+
+        def c(k):
+            return cfg.get(k)
+
+        mock_config.side_effect = c
+        get_network_address.return_value = "127.0.0.1"
+        relation_ids.return_value = ['foo:1']
+        related_units.return_value = ['unit-machine-0']
+        relation_get.return_value = 'iface'
+
+        hacluster_hooks.get_ha_nodes = mock.MagicMock()
+        conf = hacluster_hooks.get_corosync_conf()
+        self.assertEqual(conf['debug'], enabled)
+
+        self.assertTrue(hacluster_hooks.emit_corosync_conf())
+
+        with open(hacluster_hooks.COROSYNC_CONF) as fd:
+            content = fd.read()
+            if enabled:
+                pattern = 'debug: on\n'
+            else:
+                pattern = 'debug: off\n'
+
+            matches = re.findall(pattern, content, re.M)
+            self.assertEqual(len(matches), 2, str(matches))