Juju Charms Collection
glance-simplestreams-sync package

Merge lp:~freyes/charms/trusty/glance-simplestreams-sync/lp1522929-next into lp:~openstack-charmers/charms/trusty/glance-simplestreams-sync/next

  1. Trusty Tahr (14.04)
  2. lp1522929-next
  3. Merge into next
Proposed by Felipe Reyes
Status: Merged
Merged at revision: 57
Proposed branch: lp:~freyes/charms/trusty/glance-simplestreams-sync/lp1522929-next
Merge into: lp:~openstack-charmers/charms/trusty/glance-simplestreams-sync/next
Diff against target: 12 lines (+0/-2)
1 file modified
hooks/hooks.py (+0/-2)
To merge this branch: bzr merge lp:~freyes/charms/trusty/glance-simplestreams-sync/lp1522929-next
Reviewer Review Type Date Requested Status
Edward Hope-Morley Approve
Review via email: mp+282958@code.launchpad.net

Description of the change

Dear Maintainers,

This patch removes the addition of ppa:cloud-installer/simplestreams-testing during the install hook, that PPA contains a buggy version of simplestreams, the trusty version has a few security fixes applied and one patch to make it work ceph-radosgw

Best,

To post a comment you must log in.
Revision history for this message
Edward Hope-Morley (hopem) wrote :

We have had a discussion about this in https://code.launchpad.net/~freyes/charms/trusty/glance-simplestreams-sync/lp1522929/+merge/279644 and since we seem to have I'm gonna go ahead and say LGTM +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/hooks.py'
2--- hooks/hooks.py 2015-09-16 18:17:09 +0000
3+++ hooks/hooks.py 2016-01-18 15:20:45 +0000
4@@ -197,8 +197,6 @@
5 return
6 os.mkdir(directory)
7
8- hookenv.log('adding cloud-installer PPA')
9- add_source('ppa:cloud-installer/simplestreams-testing')
10 apt_update()
11
12 apt_install(packages=['python-simplestreams', 'python-glanceclient',

Subscribers

People subscribed via source and target branches