Code review comment for lp:~free.ekanayaka/landscape-client/release-upgrade-logs

Revision history for this message
Sidnei da Silva (sidnei) wrote :

Looks good, but you're defaulting to read 100k from the *beginning* of the file (logs_limit is positive)? I think it would be more useful to read from the end of the file. With that change, +1!

review: Approve

« Back to merge proposal