Merge lp:~free.ekanayaka/landscape-client/fix-release-upgrader-not-asking-for-session-id into lp:~landscape/landscape-client/trunk
Proposed by
Free Ekanayaka
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Free Ekanayaka | ||||
Approved revision: | 806 | ||||
Merged at revision: | 805 | ||||
Proposed branch: | lp:~free.ekanayaka/landscape-client/fix-release-upgrader-not-asking-for-session-id | ||||
Merge into: | lp:~landscape/landscape-client/trunk | ||||
Diff against target: |
77 lines (+14/-6) 3 files modified
landscape/broker/store.py (+1/-1) landscape/package/releaseupgrader.py (+13/-3) landscape/package/tests/test_releaseupgrader.py (+0/-2) |
||||
To merge this branch: | bzr merge lp:~free.ekanayaka/landscape-client/fix-release-upgrader-not-asking-for-session-id | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chris Glass (community) | Approve | ||
Björn Tillenius (community) | Approve | ||
Review via email: mp+244573@code.launchpad.net |
Commit message
This branch fixes the release upgrader to ask for a session ID before
attempting to send a message.
Unfortunately the test setUp was getting it by hand ignoring that real
code would not do the same.
Description of the change
This branch fixes the release upgrader to ask for a session ID before
attempting to send a message.
Unfortunately the test setUp was getting it by hand ignoring that real
code would not do the same.
To post a comment you must log in.
Looks good. Minor comment about test coverage, but +1.