Code review comment for lp:~free.ekanayaka/landscape-charm/run-schema-script

Revision history for this message
Chad Smith (chad.smith) wrote :

[1] Unrelated to this branch: the rework in rev 220 broke the lint makefile target, this breaks charm store automated testing that is done which exercises lint targets if they exist for a charm. We need to avoid trying to lint tests dir which no longer exists, and we should ignore charmhelpers and old subdirs in our lints.

=== modified file 'Makefile'
--- Makefile revid:<email address hidden>
+++ Makefile 2015-02-10 10:55:08 +0000
@@ -36,9 +36,9 @@

 lint:
  flake8 --exclude=charmhelpers hooks
- pyflakes3 tests dev/update-charm-revision-numbers
- find . -name *.py -print0 | xargs -0 pep8
- pep8 tests dev/update-charm-revision-numbers
+ pyflakes3 dev/update-charm-revision-numbers
+ find . -name *.py -not -path "./old/*" -not -path "*/charmhelpers/*" -print0 | xargs -0 pep8
+ pep8 dev/update-charm-revision-numbers

 clean: clean-integration-test

+1 on charm changes.

review: Approve

« Back to merge proposal