Code review comment for ~freddie-akeroyd/epics-base:nan_inf_tests

Revision history for this message
Andrew Johnson (anj) wrote :

Group 10/4:

Suggest epicsCalcTest() should compare the string expression against the known expected result (for inf/nan calculations) so don't use Freddie's change as currently written to this file.

The epicsMathTest() changes are tricking the optimizer, which is a brittle thing. Idea is to concentrate these kinds of tests in this file, to document the known issues. As a result removing the compiler checks and calls to testToDo() from here is less helpful, we'd still like to see those until we stop building on compilers that fail. Having ToDo tests pass isn't a problem.

AI on MAD to merge and fix this.

review: Needs Fixing

« Back to merge proposal