Merge lp:~fraser-waters08/spud/copy-paste into lp:spud

Proposed by Fraser Waters
Status: Merged
Merged at revision: 411
Proposed branch: lp:~fraser-waters08/spud/copy-paste
Merge into: lp:spud
Diff against target: 0 lines
To merge this branch: bzr merge lp:~fraser-waters08/spud/copy-paste
Reviewer Review Type Date Requested Status
Fraser Waters Needs Fixing
Patrick Farrell Pending
Review via email: mp+67321@code.launchpad.net

Description of the change

Can now copy and paste between Diamond and XML text.

To post a comment you must log in.
Revision history for this message
Fraser Waters (fraser-waters08) wrote :

Bug in pasting into zeroormore/oneormore trees. Need to fix that before merge.

review: Needs Fixing
Revision history for this message
Fraser Waters (fraser-waters08) wrote :

> Bug in pasting into zeroormore/oneormore trees. Need to fix that before merge.

Bug fixed in revision 412.

lp:~fraser-waters08/spud/copy-paste updated
414. By Fraser Waters

Added rightclick popup Copy/Paste menu.

Revision history for this message
Patrick Farrell (pefarrell) wrote :

Right-click paste in the treeview doesn't work.

In the copy callback, can you check if what's being pasted is valid XML, and if not, print it on the statusbar?

lp:~fraser-waters08/spud/copy-paste updated
415. By Fraser Waters

Fixed libglade warnings. Xml is now validated before pasteing. Hooked
up copy paste events in popup.

416. By Fraser Waters

Bug fixes.

Revision history for this message
Patrick Farrell (pefarrell) wrote :

Read the XML, and then expand the item in the treeview.

Once that's fixed, I think it's great to commit. Nice work!

lp:~fraser-waters08/spud/copy-paste updated
417. By Fraser Waters

Read xml in paste before doing node expansion.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches