Merge lp:~frankencode/ubuntu-calendar-app/testrun-fix into lp:ubuntu-calendar-app

Proposed by Frank Mertens
Status: Merged
Merged at revision: 13
Proposed branch: lp:~frankencode/ubuntu-calendar-app/testrun-fix
Merge into: lp:ubuntu-calendar-app
Diff against target: 9 lines (+1/-1)
1 file modified
testrun.sh (+1/-1)
To merge this branch: bzr merge lp:~frankencode/ubuntu-calendar-app/testrun-fix
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Mario Boikov (community) Approve
Frank Mertens (community) trust me Approve
Review via email: mp+155871@code.launchpad.net

Commit message

Fixed the testrun.sh script: made it use an interactive shell.

To post a comment you must log in.
Revision history for this message
Frank Mertens (frankencode) wrote :

As discussed on the mailing lists device specific settings reside in ~phablet/.bashrc. Therefore the testrun.sh script needs to invoke the app in an interactive shell. Tested the new script: runs well. Without: dbus issues.

review: Approve (trust me)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mario Boikov (mariob) wrote :

Trusting you since I can test it but it seems to work

review: Approve
Revision history for this message
Mario Boikov (mariob) wrote :

> Trusting you since I can test it but it seems to work

can/can't :)

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'testrun.sh'
2--- testrun.sh 2013-03-06 18:35:00 +0000
3+++ testrun.sh 2013-03-28 00:11:20 +0000
4@@ -1,4 +1,4 @@
5 #! /bin/bash -ex
6
7 rsync -aHv ./ phablet@nexus:/tmp/Calendar/
8-ssh -t phablet@nexus 'cd /tmp/Calendar && GRID_UNIT_PX=18 qmlscene --desktop_file_hint=$PWD/Calendar.desktop $PWD/calendar.qml'
9+ssh -t phablet@nexus 'cd /tmp/Calendar && echo "qmlscene --desktop_file_hint=$PWD/Calendar.desktop $PWD/calendar.qml" > runme.sh && chmod +x runme.sh && bash -i runme.sh'

Subscribers

People subscribed via source and target branches

to status/vote changes: