Merge lp:~frankencode/ubuntu-calendar-app/startup-performance-fix into lp:ubuntu-calendar-app

Proposed by Frank Mertens
Status: Merged
Approved by: Mario Boikov
Approved revision: 9
Merged at revision: 9
Proposed branch: lp:~frankencode/ubuntu-calendar-app/startup-performance-fix
Merge into: lp:ubuntu-calendar-app
Diff against target: 21 lines (+2/-2)
1 file modified
MonthView.qml (+2/-2)
To merge this branch: bzr merge lp:~frankencode/ubuntu-calendar-app/startup-performance-fix
Reviewer Review Type Date Requested Status
Mario Boikov (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+153929@code.launchpad.net

Commit message

Fix: Prevent the instantiation of all months on startup because of unfinished initialization of window geometry.

Description of the change

Fix: Prevent the instantiation of all months on startup because of unfinished initialization of window geometry.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mario Boikov (mariob) wrote :

Confirmed that the workaround will prevent unnecessary delegate initialization at start-up

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MonthView.qml'
2--- MonthView.qml 2013-03-10 21:45:05 +0000
3+++ MonthView.qml 2013-03-18 20:46:28 +0000
4@@ -99,7 +99,7 @@
5 property var monthStart0: today.monthStart()
6 }
7
8- width: parent.width
9+ width: parent.width > 0 ? parent.width : 1
10 height: intern.squareUnit * 6 + intern.verticalMargin * 2
11
12 interactive: !compressed
13@@ -184,7 +184,7 @@
14 }
15 }
16
17- // Component.onCompleted: console.log("Created delegate for month", index, monthStart, gridStart, currentWeekRow, currentWeekRowReal)
18+ // Component.onCompleted: console.log("Created delegate for month", index, monthStart, monthView.width, monthView.height)
19 }
20
21 Label {

Subscribers

People subscribed via source and target branches

to status/vote changes: