Merge lp:~frankban/python-shelltoolbox/add-extra-repositories into lp:python-shelltoolbox

Proposed by Francesco Banconi
Status: Merged
Approved by: Gary Poster
Approved revision: 13
Merged at revision: 13
Proposed branch: lp:~frankban/python-shelltoolbox/add-extra-repositories
Merge into: lp:python-shelltoolbox
Diff against target: 0 lines
To merge this branch: bzr merge lp:~frankban/python-shelltoolbox/add-extra-repositories
Reviewer Review Type Date Requested Status
Gary Poster (community) Approve
Review via email:

Description of the change

== Changes ==

- Fixed a typo in `install_extra_repositories`.
- `install_extra_repositories` now works correctly cross-distributions.
- `run` helper improvements:
   - None is ignored if passed as positional argument.
   - The function accepts popen kwargs.

To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

Thank you Francesco!

- Please add a description of the kwargs to the run docstring
- As we discussed, please add a brief explanatory comment as to why assume_yes has the Lucid-related logic that it does.

Looks good


review: Approve
Revision history for this message
Francesco Banconi (frankban) wrote :

Thank you Gary.

14. By Francesco Banconi

Added comments.

Preview Diff



People subscribed via source and target branches