Merge lp:~frankban/python-shelltoolbox/add-extra-repositories into lp:python-shelltoolbox
Proposed by
Francesco Banconi
on 2012-03-02
Status: | Merged |
---|---|
Approved by: | Gary Poster on 2012-03-02 |
Approved revision: | 13 |
Merged at revision: | 13 |
Proposed branch: | lp:~frankban/python-shelltoolbox/add-extra-repositories |
Merge into: | lp:python-shelltoolbox |
Diff against target: | 0 lines |
To merge this branch: | bzr merge lp:~frankban/python-shelltoolbox/add-extra-repositories |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary Poster (community) | 2012-03-02 | Approve on 2012-03-02 | |
Review via email:
|
Description of the change
== Changes ==
- Fixed a typo in `install_
- `install_
- `run` helper improvements:
- None is ignored if passed as positional argument.
- The function accepts popen kwargs.
To post a comment you must log in.
Francesco Banconi (frankban) wrote : | # |
Thank you Gary.
lp:~frankban/python-shelltoolbox/add-extra-repositories
updated
on 2012-03-02
- 14. By Francesco Banconi on 2012-03-02
-
Added comments.
Thank you Francesco!
- Please add a description of the kwargs to the run docstring
- As we discussed, please add a brief explanatory comment as to why assume_yes has the Lucid-related logic that it does.
Looks good
Gary