Merge lp:~frankban/lpsetup/split-files into lp:lpsetup
Proposed by
Francesco Banconi
on 2012-03-12
| Status: | Merged |
|---|---|
| Merged at revision: | 2 |
| Proposed branch: | lp:~frankban/lpsetup/split-files |
| Merge into: | lp:lpsetup |
| Diff against target: | 0 lines |
| To merge this branch: | bzr merge lp:~frankban/lpsetup/split-files |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Benji York (community) | code | 2012-03-12 | Approve on 2012-03-12 |
|
Review via email:
|
|||
Description of the Change
== Changes ==
- Created an lpsetup project (personal, but this should change).
- Splitted the code present in `lpsetup.py` into smaller files.
- Added distribution files.
- The script now uses helpers from `python-
- Fixed some doctests.
- Fixed the way `file_append` and `file_prepend` are used.
This is an incremental change, not tested, but required to start working on
lpsetup as a project and not just a standalone script.
To post a comment you must log in.
lp:~frankban/lpsetup/split-files
updated
on 2012-03-12
- 9. By Francesco Banconi on 2012-03-12
-
Changes from review.

As discussed in IRC, this review is of the project structure, ignoring
the (small) changes also made in this branch.
The README suggests that running both "lp-setup install" and "lp-setup
lxc-install" are required. Phrasing that indicates that they are
alternatives to one another would be an improvement.
There is a commented-out "install_requires" in setup.py that should be
removed.
We should have something a bit less individual for the author and
author_email values in setup.py. Probably something like "Launchpad
Developers" and the launchpad-dev list.
I'm not sure the data_files-related code is necessary. Setuptools can
interrogate bzr to differentiate the files that are part of the project
vs. the incidental files (pyc, TAGS, etc.).
I wouldn't do it in this round, but we may soon want to start using a
simple buildout config, primarily so we can have a real testrunner.