Merge lp:~frankban/lpsetup/lang-c into lp:lpsetup

Proposed by Francesco Banconi
Status: Merged
Merged at revision: 5
Proposed branch: lp:~frankban/lpsetup/lang-c
Merge into: lp:lpsetup
Diff against target: 34 lines (+3/-3)
2 files modified
lpsetup/settings.py (+2/-2)
lpsetup/subcommands/install.py (+1/-1)
To merge this branch: bzr merge lp:~frankban/lpsetup/lang-c
Reviewer Review Type Date Requested Status
Benji York (community) code Approve
Review via email: mp+97895@code.launchpad.net

Description of the change

The env var LANG=C is set during the installation of launchpad developer packages.
This way we can avoid installing language-pack-en

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

Nice.

review: Approve (code)
Revision history for this message
Francesco Banconi (frankban) wrote :

Thanks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lpsetup/settings.py'
2--- lpsetup/settings.py 2012-03-09 10:14:32 +0000
3+++ lpsetup/settings.py 2012-03-16 15:10:04 +0000
4@@ -12,7 +12,7 @@
5 'ppa:launchpad/ppa',
6 'ppa:bzr/ppa',
7 )
8-BASE_PACKAGES = ['ssh', 'bzr', 'language-pack-en']
9+BASE_PACKAGES = ['ssh', 'bzr']
10 CHECKOUT_DIR = '~/launchpad/branches'
11 DEPENDENCIES_DIR = '~/launchpad/dependencies'
12 DHCP_FILE = '/etc/dhcp/dhclient.conf'
13@@ -47,7 +47,7 @@
14 )
15 LP_CHECKOUT = 'devel'
16 LP_PACKAGES = [
17- 'bzr', 'launchpad-developer-dependencies', 'apache2',
18+ 'launchpad-developer-dependencies', 'apache2',
19 'apache2-mpm-worker', 'libapache2-mod-wsgi'
20 ]
21 LP_REPOS = (
22
23=== modified file 'lpsetup/subcommands/install.py'
24--- lpsetup/subcommands/install.py 2012-03-09 17:57:02 +0000
25+++ lpsetup/subcommands/install.py 2012-03-16 15:10:04 +0000
26@@ -185,7 +185,7 @@
27 call("echo 'mountall hold' | dpkg --set-selections", shell=True)
28 call('apt-get', 'update')
29 # Install base and Launchpad deb packages.
30- apt_get_install(*LP_PACKAGES)
31+ apt_get_install(*LP_PACKAGES, LANG='C')
32
33
34 def setup_launchpad(user, dependencies_dir, directory, valid_ssh_keys):

Subscribers

People subscribed via source and target branches

to all changes: